[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

2021-08-08 Thread GitBox
sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-894877198 Note that givenName is optional according to the schema. I dropped mine (and some other ids don't have them) and I have not noticed any issues. As to sn, it needs to be pr

[GitHub] [whimsy] gstein commented on pull request #120: Family First support in secretary workbench

2021-08-08 Thread GitBox
gstein commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-894875632 > We have already discussed that givenName and sn are not actually used, so it really does not matter what they are. Euh... those fields *are* used by some tools. They cannot

[GitHub] [whimsy] sebbASF merged pull request #124: Fix spelling

2021-08-08 Thread GitBox
sebbASF merged pull request #124: URL: https://github.com/apache/whimsy/pull/124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@w

Re: [GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

2021-08-08 Thread Craig Russell
tl;dr This patch is ready to merge but sebb wants to veto it. https://github.com/apache/whimsy/pull/120 The family-first checkbox and family-first form field in secretary workbench are useful for us to detect earlier than we do today a possible conflict in names of ICLA submitters. This handy

[GitHub] [whimsy] jbampton commented on pull request #124: Fix spelling

2021-08-08 Thread GitBox
jbampton commented on pull request #124: URL: https://github.com/apache/whimsy/pull/124#issuecomment-894867619 @sebbASF all done now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [whimsy] sebbASF commented on pull request #124: Fix spelling

2021-08-08 Thread GitBox
sebbASF commented on pull request #124: URL: https://github.com/apache/whimsy/pull/124#issuecomment-894859021 Thanks, but there are still changes to the board agenda test data. Please don't change any of those files. -- This is an automated message from the Apache Git Service. To respond