Re: Rakefile restarts Passenger apps before updating Gems?

2021-08-07 Thread sebb
On Sun, 8 Aug 2021 at 00:46, Sam Ruby wrote: > > On Sat, Aug 7, 2021 at 7:34 PM sebb wrote: > > > > The 'rake update' command restarts Passenger apps that have changed > > since the last update. > > > > It then goes on the update the Gems. > > ... and my touch restart.txt again. I'd overlooked t

Re: Is .ruby-version still needed?

2021-08-07 Thread Dave Fisher
Sent from my iPhone > On Aug 7, 2021, at 4:27 PM, sebb wrote: > > On Sun, 8 Aug 2021 at 00:18, Sam Ruby wrote: >> >>> On Sat, Aug 7, 2021 at 6:52 PM sebb wrote: >>> >>> On Sat, 7 Aug 2021 at 16:00, Matt Sicker wrote: I probably added those at one point when I had a bunch of r

Re: Is .ruby-version still needed?

2021-08-07 Thread Matt Sicker
I don’t know enough about different versions of ruby to recommend which one to use. Whatever version we use in production would make sense here. Matt Sicker > On Aug 7, 2021, at 18:27, sebb wrote: > > On Sun, 8 Aug 2021 at 00:18, Sam Ruby wrote: >> >>> On Sat, Aug 7, 2021 at 6:52 PM sebb w

Re: Rakefile restarts Passenger apps before updating Gems?

2021-08-07 Thread Sam Ruby
On Sat, Aug 7, 2021 at 7:34 PM sebb wrote: > > The 'rake update' command restarts Passenger apps that have changed > since the last update. > > It then goes on the update the Gems. ... and my touch restart.txt again. > That seems a bit odd: would it not be better to update the Gems first, > so a

Rakefile restarts Passenger apps before updating Gems?

2021-08-07 Thread sebb
The 'rake update' command restarts Passenger apps that have changed since the last update. It then goes on the update the Gems. That seems a bit odd: would it not be better to update the Gems first, so any restarted apps pick up the new Gems? The task comment says: '# update gems and restart app

Re: Drop Gem packaging code for whimsy

2021-08-07 Thread Sam Ruby
On Sat, Aug 7, 2021 at 6:12 PM sebb wrote: > > On Sat, 7 Aug 2021 at 19:53, sebb wrote: > > > > On Sat, 7 Aug 2021 at 18:58, Sam Ruby wrote: > > > > > > On Sat, Aug 7, 2021 at 1:10 PM sebb wrote: > > > > > > > > On Sat, 7 Aug 2021 at 17:42, Sam Ruby wrote: > > > > > > > > > > On Sat, Aug 7, 20

Re: Is .ruby-version still needed?

2021-08-07 Thread sebb
On Sun, 8 Aug 2021 at 00:18, Sam Ruby wrote: > > On Sat, Aug 7, 2021 at 6:52 PM sebb wrote: > > > > On Sat, 7 Aug 2021 at 16:00, Matt Sicker wrote: > > > > > > I probably added those at one point when I had a bunch of ruby versions > > > installed. I don’t think it’s needed anymore. > > > > OK

Re: Is .ruby-version still needed?

2021-08-07 Thread Sam Ruby
On Sat, Aug 7, 2021 at 6:52 PM sebb wrote: > > On Sat, 7 Aug 2021 at 16:00, Matt Sicker wrote: > > > > I probably added those at one point when I had a bunch of ruby versions > > installed. I don’t think it’s needed anymore. > > OK I can delete the file, but what changes are needed to MACOS.md?

Re: Is .ruby-version still needed?

2021-08-07 Thread sebb
On Sat, 7 Aug 2021 at 16:00, Matt Sicker wrote: > > I probably added those at one point when I had a bunch of ruby versions > installed. I don’t think it’s needed anymore. OK I can delete the file, but what changes are needed to MACOS.md? > Matt Sicker > > > On Aug 7, 2021, at 08:22, sebb wrot

Re: Drop Gem packaging code for whimsy

2021-08-07 Thread sebb
On Sat, 7 Aug 2021 at 19:53, sebb wrote: > > On Sat, 7 Aug 2021 at 18:58, Sam Ruby wrote: > > > > On Sat, Aug 7, 2021 at 1:10 PM sebb wrote: > > > > > > On Sat, 7 Aug 2021 at 17:42, Sam Ruby wrote: > > > > > > > > On Sat, Aug 7, 2021 at 11:46 AM sebb wrote: > > > > > > > > > > On Sat, 7 Aug 20

[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

2021-08-07 Thread GitBox
sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-894711513 In case it is not obvious, I am -1 on applying this PR without a clear explanation of the benefit. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

2021-08-07 Thread GitBox
sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-894711284 You still have not explained how it helps to know the whether the family name is first or not. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [whimsy] clr-apache commented on pull request #120: Family First support in secretary workbench

2021-08-07 Thread GitBox
clr-apache commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-894710333 @sebbASF My interest in this is motivated by over 10 years of experience filing ICLAs and IMHO adding family first flag to the ICLA and secretary workbench is an improvement

[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

2021-08-07 Thread GitBox
sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-894704206 We have already discussed that givenName and sn are not actually used, so it really does not matter what they are. givenName is optional to the LDAP schema, so can be omitted

Re: [GitHub] [whimsy] clr-apache commented on pull request #120: Family First support in secretary workbench

2021-08-07 Thread Craig Russell
I'd appreciate it if you all could take a look at the changes to secretary workbench. If you're on the family-first branch I've been testing using config/setupmymac and the code works just as I like it to. Future improvements can include delegating the LDAP sn and givenName to methods in lib/p

[GitHub] [whimsy] clr-apache commented on pull request #120: Family First support in secretary workbench

2021-08-07 Thread GitBox
clr-apache commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-894702891 The family first flag allows for the ICLA submitter to tell secretary that the names are culturally consistent. Secretary can then create the file name consistent with the curre

[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

2021-08-07 Thread GitBox
sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-894702563 What is the use-case for this, now that the workbench does checks for name clashes? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [whimsy] asfgit closed issue #123: Podling resolutionLink and resolutionUrl are not output in public_podlings.json

2021-08-07 Thread GitBox
asfgit closed issue #123: URL: https://github.com/apache/whimsy/issues/123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@whimsic

[GitHub] [whimsy] dave2wave opened a new issue #123: Podling resolutionLink and resolutionUrl are not output in public_podlings.json

2021-08-07 Thread GitBox
dave2wave opened a new issue #123: URL: https://github.com/apache/whimsy/issues/123 In c0198aa support for resolutionLink and resolutionUrl were added. For some reason these do not flow through to https://whimsy.apache.org/public/public_podlings.json -- This is an automated message from

Re: Drop Gem packaging code for whimsy

2021-08-07 Thread sebb
On Sat, 7 Aug 2021 at 18:58, Sam Ruby wrote: > > On Sat, Aug 7, 2021 at 1:10 PM sebb wrote: > > > > On Sat, 7 Aug 2021 at 17:42, Sam Ruby wrote: > > > > > > On Sat, Aug 7, 2021 at 11:46 AM sebb wrote: > > > > > > > > On Sat, 7 Aug 2021 at 16:28, Sam Ruby wrote: > > > > > > > > > > The 'gem' li

[GitHub] [whimsy] dave2wave opened a new issue #122: WHIMSY-357 - Support git write of calendar.md in agenda tool

2021-08-07 Thread GitBox
dave2wave opened a new issue #122: URL: https://github.com/apache/whimsy/issues/122 Since the apache.org website is now in git there needs to be support for writing (commit/push) in the git.rb module. Specifically updating `https://github.com/apache/www-site/blob/main/content/founda

Re: Testing secretary workbench

2021-08-07 Thread Craig Russell
Good news. Thanks to Sam for working with me to get my local environment back to where I can usefully test the family-first ICLA. I still have issues/questions that I'll raise in another thread. I also will try Sebb's suggestions to import new test ICLAs into my testing environment. Thanks, Cr

Re: Drop Gem packaging code for whimsy

2021-08-07 Thread Sam Ruby
On Sat, Aug 7, 2021 at 1:10 PM sebb wrote: > > On Sat, 7 Aug 2021 at 17:42, Sam Ruby wrote: > > > > On Sat, Aug 7, 2021 at 11:46 AM sebb wrote: > > > > > > On Sat, 7 Aug 2021 at 16:28, Sam Ruby wrote: > > > > > > > > The 'gem' lines with path values in Gemfiles are effectively a way to > > > >

Re: Drop Gem packaging code for whimsy

2021-08-07 Thread sebb
On Sat, 7 Aug 2021 at 17:42, Sam Ruby wrote: > > On Sat, Aug 7, 2021 at 11:46 AM sebb wrote: > > > > On Sat, 7 Aug 2021 at 16:28, Sam Ruby wrote: > > > > > > The 'gem' lines with path values in Gemfiles are effectively a way to > > > add another part of the source tree to the ruby lib path. > >

Re: Drop Gem packaging code for whimsy

2021-08-07 Thread Sam Ruby
On Sat, Aug 7, 2021 at 11:46 AM sebb wrote: > > On Sat, 7 Aug 2021 at 16:28, Sam Ruby wrote: > > > > The 'gem' lines with path values in Gemfiles are effectively a way to > > add another part of the source tree to the ruby lib path. > > But is the Gem packaging code still needed for Whimsy? Inde

Re: Drop Gem packaging code for whimsy

2021-08-07 Thread sebb
On Sat, 7 Aug 2021 at 16:28, Sam Ruby wrote: > > The 'gem' lines with path values in Gemfiles are effectively a way to > add another part of the source tree to the ruby lib path. But is the Gem packaging code still needed for Whimsy? I've created a branch to work on this. It mostly works, but it

Re: Drop Gem packaging code for whimsy

2021-08-07 Thread Sam Ruby
The 'gem' lines with path values in Gemfiles are effectively a way to add another part of the source tree to the ruby lib path. - Sam Ruby On Sat, Aug 7, 2021 at 8:43 AM sebb wrote: > > AFAICT it is not necessary for the whimsy library code to be packaged as a > Gem. > > However there is still

Re: Is .ruby-version still needed?

2021-08-07 Thread Matt Sicker
I probably added those at one point when I had a bunch of ruby versions installed. I don’t think it’s needed anymore. Matt Sicker > On Aug 7, 2021, at 08:22, sebb wrote: > > The file .ruby-version is mentioned in MACOS.md in relation to rbenv. > > However the contents are 2.4.1, having previ

Is .ruby-version still needed?

2021-08-07 Thread sebb
The file .ruby-version is mentioned in MACOS.md in relation to rbenv. However the contents are 2.4.1, having previously been 2.5.5. Both seem seriously out of date, so it looks like the file is not needed. Sebb

Drop Gem packaging code for whimsy

2021-08-07 Thread sebb
AFAICT it is not necessary for the whimsy library code to be packaged as a Gem. However there is still some code relating to the packaging. This may or may not still work. I think it would be best to drop the code to reduce the burden on future maintainers. Sebb