[quote="mehrdadh, post:14, topic:12334"]
Regarding the guideline/tooling, in my experience I see that people spend a
good time on writing the PR description and usually PR description includes
enough information to get a good understanding of the commit after merge. I
wonder if there’s a way t
@gromero thanks for initiating this conversation. I think this is an important
topic to consider as the TVM contributions are growing. Having a guideline that
the community has accepted is important so the reviewers could use as a
reference to make decisions. But more importantly, I totally ag
Thanks @gromero for starting this RFC! I think sorting out commit messages will
have a very good impact down the line in organising the project as a whole.
Adding automation to check/enforce this is a great and I support it very much,
but I think the important thing at project level as a resul
cc : @masahi @Lunderberg
---
[Visit
Topic](https://discuss.tvm.apache.org/t/commit-message-guideline/12334/12) to
respond.
You are receiving this because you enabled mailing list mode.
To unsubscribe from these emails, [click
here](https://discuss.tvm.apache.org/email/unsubscribe/3b0038
Thanks @gromero for taking this initiative.
I would actually push us to take a pragmatic route to enforce these (kind of
agreeing @driazati ) given the distributed nature of the TVM/OSS project,
failing that we fallback to being at least a "guideline" -- which we dont have
at the minute :) .
> OTOH overt time I did realize that is not always the case that contributors
> void push force and eventually some will do it. BTW, we don’t have any rule /
> guideline to encourage (or dis-encourage it). Let me know if besides keeping
> the conversations in the PR (which is ultimately a GH l
[quote="gromero, post:8, topic:12334"]
I think the onus should *not* be on the reviewers, and I think that an ask like
that would avoid it: it’s a submitter’s duty to write a good commit message,
just like a correct/good code.
[/quote]
I definitely agree we should try these suggestions and add
[quote="driazati, post:5, topic:12334, full:true"]
These guidelines are definitely good to have and I think we should codify them
in our docs! One big problem we have today is clicking the merge button on
GitHub defaults to a bad commit message which [[RFC] Allow merging via PR
comments](https
@tqchen Thanks a lot for input and support. I've changed the category as
pre-RFC and I'll add a few examples to the initial test. That's indeed
necessary I agree.
---
[Visit
Topic](https://discuss.tvm.apache.org/t/commit-message-guideline/12334/7) to
respond.
You are receiving this beca
Hi Tristan. Good question ;)
In a sense that issue could be put into the class of the issues I mentioned as
"Github-specif issues", because to me ideally such a comments should never
exist in the first place. They exist in my understanding primarily because we
want to keep the PR conversation
10 matches
Mail list logo
