> OTOH overt time I did realize that is not always the case that contributors > void push force and eventually some will do it. BTW, we don’t have any rule / > guideline to encourage (or dis-encourage it). Let me know if besides keeping > the conversations in the PR (which is ultimately a GH limitation I think) > there are other advantages on not force pushing in the review process we > currently use on GH.
I think some people prefer that new changes to a PR come as new commits so that they can review them on a per-commit basis instead of having to re-review the entire PR. > So that’s my suggestion: add a guideline saying that non-trivial additional > commit messages should try to capture the essence of the additional changes > taking into account what/how it affects the initial commits. I think this is a reasonable thing to ask for, but I'm not sure when/how these additional changes should be merged into the final commit message. --- [Visit Topic](https://discuss.tvm.apache.org/t/commit-message-guideline/12334/10) to respond. You are receiving this because you enabled mailing list mode. To unsubscribe from these emails, [click here](https://discuss.tvm.apache.org/email/unsubscribe/6e7649f7312c7eff388673e928902a6aa852b0b1f128187bdd9183fb46c45605).
