[Apache TVM Discuss] [Development/RFC] [mini-RFC] Name mangling in AOT

2021-05-11 Thread Andrew Reusch via Apache TVM Discuss
@tqchen @manupa-arm @mjs @giuseros great discussions so far! > Identifiers that begin with underscore are reserved by the C standard. > Conformant C code should not use them, dropping the _ and using just “tvm_…” > would be conformant. I agree with this. Do we need to consider distinguishing

[Apache TVM Discuss] [Development/RFC] mini-RFC] Name mangling in AOT

2021-05-11 Thread tqchen via Apache TVM Discuss
I agree that having a common prefix is helpful in the dso landscape to clearly identify function generated by tvm. To faciliate discussion, consider the following code ```python m = tvm.runtime.load_module("x.so") # Option P0: require explicit query using tvm_run run = m["tvm_run"] # Option P

[Apache TVM Discuss] [Development/RFC] mini-RFC] Name mangling in AOT

2021-05-11 Thread Marcus Shawcroft via Apache TVM Discuss
Identifiers that begin with underscore are reserved by the C standard. Conformant C code should not use them, dropping the _ and using just "tvm_..." would be conformant. --- [Visit Topic](https://discuss.tvm.apache.org/t/mini-rfc-name-mangling-in-aot/9907/8) to respond. You are recei

[Apache TVM Discuss] [Development/RFC] mini-RFC] Name mangling in AOT

2021-05-11 Thread Manupa Karunaratne via Apache TVM Discuss
Hi @areusch @tqchen @giuseros I think its best to use _tvm prefix nonetheless. -- so we dont pollute a namespace based on a user given variable. I dont follow why a "prefix" necessarily mean user being able to select it? If "prefix" is not the right term we should not call it a prefix. The g