[TVM Discuss] [Development/RFC] Introducing TVM.NET for bringing TVM features into .NET world

2020-04-28 Thread Jeremiah Morrill via TVM Discuss
Sorry. Actually, I may have been mistaken on the use of the isView after a closer look at the Java impl and the test code here: https://github.com/apache/incubator-tvm/blob/1dcf8a16ee3a93dff5ffc1ad1a66892eda03ef13/jvm/core/src/test/java/org/apache/tvm/contrib/GraphRuntimeTest.java --- [Vis

[TVM Discuss] [Development/RFC] Introducing TVM.NET for bringing TVM features into .NET world

2020-04-28 Thread Jeremiah Morrill via TVM Discuss
Others may confirm if this is correct, but I believe they implement this in the Java version by keeping track if the managed NDArray is the owner of the native handle, using that to determine if it can release it. https://github.com/apache/incubator-tvm/blob/1dcf8a16ee3a93dff5ffc1ad1a66892eda0

[TVM Discuss] [Development/RFC] Introducing TVM.NET for bringing TVM features into .NET world

2020-04-25 Thread Jeremiah Morrill via TVM Discuss
I can probably give more in depth review, but here's some suggestions with a quick look: `IDisposable` - On classes such as Module or NDArray, I would implement the IDisposable interface to be consistent with dotnet, allowing usage with the `using` statement. ~Module() {

[TVM Discuss] [Development/RFC] Introducing TVM.NET for bringing TVM features into .NET world

2020-04-19 Thread Jeremiah Morrill via TVM Discuss
As an example for @ANSHUMAN.TRIPATHY for just using the C API, I generated the C# p/invoke (using [this lib](https://github.com/xoofx/CppAst.CodeGen)). Since it's autogen'd don't rely on it 100%, so some of it will be wrong! https://gist.github.com/jmorrill/0f65876c2a9b8b7c335e008393cbddbc