[TVM Discuss] [Development/RFC] [Closed][Discuss]Addional points on top of Module Based Model Runtime Interface

2020-05-13 Thread ANSHUMAN TRIPATHY via TVM Discuss
@tqchen: Thank you very much for clarifying all the points in details. Will sure cover all the points you mentioned in future RFCs. --- [Visit Topic](https://discuss.tvm.ai/t/closed-discuss-addional-points-on-top-of-module-based-model-runtime-interface/6663/4) to respond. You are receivi

[TVM Discuss] [Development/RFC] [RFC] Relay to ONNX

2020-05-13 Thread Mahesh Ambule via TVM Discuss
Ok. Thanks for clarification. I will update the PR. --- [Visit Topic](https://discuss.tvm.ai/t/rfc-relay-to-onnx/6101/26) to respond. You are receiving this because you enabled mailing list mode. To unsubscribe from these emails, [click here](https://discuss.tvm.ai/email/unsubscribe/87c25

[TVM Discuss] [Development/RFC] [RFC] Relay to ONNX

2020-05-13 Thread tqchen via TVM Discuss
I don;t think we need to do that. Just like the case of SourceModule, they are not registered anywhere. As the code base refactors further, we could introduce it to the target built, when it is clear that the case of ONNX requires the IRModule to contain relay functions instead of TIR funct

[TVM Discuss] [Development/RFC] [Discuss]Addional points on top of Module Based Model Runtime Interface

2020-05-13 Thread tqchen via TVM Discuss
First of all, given that the topic is still relates to the Module based runtime interface. I think it should be discussed that that thread. I am not too sure about originality arugment. In a nutshell though, we should always want to ask whether the features is needed, the additional engineeri

[TVM Discuss] [Development/RFC] [RFC] Relay to ONNX

2020-05-13 Thread Mahesh Ambule via TVM Discuss
@tqchen, Just to be on same page. Could you please confirm below? We need NOT to register ONNXModule as "target.build.onnx". If registered this way, it will get invoked from here when we specify target as "onnx". https://github.com/apache/incubator-tvm/blob/2cd987d92724be0f859bfb624ce797f9c7016

[TVM Discuss] [Development/RFC] [RFC] Relay to ONNX

2020-05-13 Thread tqchen via TVM Discuss
W don't have to strictly go through the TIR part, as the target only means IRModule-> runtime::Module. It is totally fine for target to take in IRModule that contains relay functions. I agree that it would be useful to have a ONNXModule as a runtime module. --- [Visit Topic](https://discu

[TVM Discuss] [Development/RFC] [Discuss]Addional points on top of Module Based Model Runtime Interface

2020-05-13 Thread ANSHUMAN TRIPATHY via TVM Discuss
cc @tqchen, @FrozenGene, @haichen, @jonso, @liangfu, @whomallinterested. --- [Visit Topic](https://discuss.tvm.ai/t/discuss-addional-points-on-top-of-module-based-model-runtime-interface/6663/2) to respond. You are receiving this because you enabled mailing list mode. To unsubscribe from

[TVM Discuss] [Development/RFC] [RFC] Relay to ONNX

2020-05-13 Thread Mahesh Ambule via TVM Discuss
@smallcoscat, Thanks. I also followed this tutorial and was able to create ONNX codegen for external runtime. Relevant code in this PR: https://github.com/maheshambule/tvm/pull/9 However, as suggested by @tqchen when I tried to implement 'ONNX' as target (and not as external codegen), I am fa

[TVM Discuss] [Development/RFC] [Discuss]Addional points on top of Module Based Model Runtime Interface

2020-05-13 Thread ANSHUMAN TRIPATHY via TVM Discuss
Hi All, This thread will be on top of Original Thread of [Module Based Model Runtime Interface](https://discuss.tvm.ai/t/discuss-module-based-model-runtime-interface/5025). As i believe the original thread is already been so long, so it will lose originality if these points being discussed th

[TVM Discuss] [Development/RFC] [RFC] Relay to ONNX

2020-05-13 Thread Ellaine via TVM Discuss
Hi @tqchen and @maheshambule, Refer to TVM tutorial [Bring Your Own Codegen To TVM](https://docs.tvm.ai/dev/relay_bring_your_own_codegen.html), where details how to create a self-defined c source module codegen. However, ONNX is not a _C_ source module, we should define an ONNX module node f