[GitHub] trafficserver pull request: TS-4072 Diagnostic log rolling races

Github user chaiman commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/568#discussion_r63659601 --- Diff: lib/ts/Diags.cc --- @@ -625,11 +625,14 @@ Diags::should_roll_diagslog() fflush(diags_log->m_fp); if (diags_

[GitHub] trafficserver pull request: TS-4072 Diagnostic log rolling races

Github user chaiman commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/568#discussion_r63660164 --- Diff: lib/ts/Diags.cc --- @@ -642,11 +645,14 @@ Diags::should_roll_diagslog() if (diags_log->roll()) { --- End d