Github user chaiman commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/568#discussion_r63659601
--- Diff: lib/ts/Diags.cc ---
@@ -625,11 +625,14 @@ Diags::should_roll_diagslog()
fflush(diags_log->m_fp);
if (diags_log->roll()) {
--- End diff --
The old file don't need to be closed in diags_log->roll(). close old
file should at destructor of old_diags. in addition,
this will cause crash because of writing to closed file
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
