Re: broken tsqa dependencies?

Looks like you are missing python's decorator package (python-decorator) which it seems that httpbin requires (and I see is in its requirements.txt), so I'm not sure how you don't have it installed ;). If you do "make clean" and "make test" it should recreate the virtualenv-- does that help? On Su

Re: broken tsqa dependencies?

I assume that helped? (since there was a smiley face) ;) On Tue, May 12, 2015 at 10:08 PM, James Peach wrote: > > > On May 12, 2015, at 2:54 PM, Thomas Jackson > wrote: > > > > Looks like you are missing python's decorator package (python-decorator) > which it

Re: Removing CHANGES file from git

+1 on killing manual CHANGES file :D On Fri, May 29, 2015 at 7:58 AM, Alan Carroll < solidwallofc...@yahoo-inc.com.invalid> wrote: > +1 on making CHANGES automated and not manual. > >

Re: [IMPORTANT] Procedure around committing pull requests (and commits in general)

+1 for automatic tests on PRs :D We'd have to check with leif on what the jenkins budget looks like, but I think its probably reasonable to run a subset of the tests on PRs. I'm thinking: - build - regression - make test - tsqa All on a centos box (since thats the minimum required pl

Re: TLS Session Ticket: Key Rotation

So as I read this thread we have a couple points: - Global key instead of per-ssl_multicert line - Fix issue with traffic_line -x not being transactional The one point that seems to have been dropped is how the keys themselves get rotated. I personally don't particuarly like the idea of hav

Re: TLS Session Ticket: Key Rotation

Reply inline On Tue, Aug 25, 2015 at 2:58 PM, James Peach wrote: > > > On Aug 25, 2015, at 2:13 PM, Thomas Jackson > wrote: > > > > So as I read this thread we have a couple points: > > > > - Global key instead of per-ssl_multicert line > >

Re: tsqa is disabled on our CI as of now

*TL;DR: if you make a commit, and the tests fail-- there is a high probability that your code change broke something. Please take the time to figure out if the bug was you or not, and if it isn't let someone know-- the community can help. TSQA is back on, but tsqa-lint is off for now.* I can under

Re: tsqa is disabled on our CI as of now

Tsqa-lint is intended to pass, but if no one ever looks at the mails then they never get better. On Sep 18, 2015 6:34 PM, "Leif Hedstrom" wrote: > > > On Sep 18, 2015, at 3:32 PM, Thomas Jackson > wrote: > > > > *TL;DR: if you make a commit, and the tests fail

Re: tsqa is disabled on our CI as of now

n, Sep 21, 2015 at 9:04 AM Thomas Jackson > wrote: > > > Tsqa-lint is intended to pass, but if no one ever looks at the mails then > > they never get better. > > On Sep 18, 2015 6:34 PM, "Leif Hedstrom" wrote: > > > > > > > > > On Sep 18

Re: github pull requests for all code contributions

Once this process is in "officially" I can set up some subset of jenkins tests to run on opened/updated PRs. We could (for example) run a clang check, regression, and tsqa on centos. The goal would not be complete coverage, but some output to give the reviewer some more confidence it will work. Thi

Remove "congestion control" feature

I'd like to propose we deprecate and remove the "congestion control" features within ATS. Currently this feature is disabled by default, and from my interactions I can't seem to find anyone that uses this feature. In addition, the majority of this functionality is covered with `origin_max_connectio

Re: Remove "congestion control" feature

ear future. So, unless there are strong reasons > that indicate this feature not working well in conjunction with other > features and is not easy to fix without breaking a lot of things around, > I'd prefer to continue to keep the feature. > > Thanks, > > Sudheer > >

Re: Remove "congestion control" feature

ndicate this feature not working well in conjunction with other features and is not easy to fix without breaking a lot of things around, I'd prefer to continue to keep the feature. Thanks, Sudheer On Monday, May 9, 2016 5:57 PM, Thomas Jackson wrote: I'd like to propose we deprecate a

Re: [GitHub] trafficserver pull request: TS-4439 Reimplement TSHttpTxnConfigFin...

We already pull stl in the core in a couple other places. And to Brian's point since this is effectively a constant (never mutates) the allocations don't matter. On May 13, 2016 6:21 AM, "zwoop" wrote: > Github user zwoop commented on the pull request: > > > https://github.com/apache/trafficserve

Re: Can we remove proxy.config.http.parse.allow_non_http?

+1 to removing (and setting default to 0) If we get to the point of getting protocol plugins back (so that we can support non-http) -- we should make this check pluggable per protocol-plugin, but since that isn't whats happening-- we can just remove this one. On Wed, Jun 29, 2016 at 9:20 PM, Sudh

Fall 2016 ATS summit

A friendly reminder for all those interested, the semi-annual ATS summit is this week! This time around it will be held at LinkedIn's Sunnyvale campus. The full schedule is posted on the wiki , but as a quick reminder the bar camp (ha

Fall 2016 ATS summit

Now that the summit has come and gone, I wanted to say thanks to everyone for making the Fall 2016 ATS summit such a success! We had record attendance (by my count: 73 in person and 8 on VC). Its great to see the community continue to grow! And for all those who were unable to attend (or want to r

PATCH: fix for the docs

somewhat incomplete-- if a response has cache control directives it will be cached regardless of response code. This is my first commit to the docs, so hopefully I've done it correctly if not please let me know! Thomas Jackson Index: content/docs/trunk/admin/configuration-

Re: Proposal: on insert client ip

+1 on config cleanup On Sep 11, 2013 8:01 PM, "James Peach" wrote: > On Sep 10, 2013, at 10:18 PM, Yongming Zhao wrote: > > > > > we have a way to insert and remove the Client-ip header, which is to > record the UA ip address: > > > > proxy.config.http.anonymize_remove_client_ip > > > > INT > >

Re: PATCH: fix for the docs

rg/jira/browse/TS-2303 On Fri, Oct 25, 2013 at 4:41 PM, Brian Geffon wrote: > Hey Thomas, > It's best to create a JIRA ticket at > https://issues.apache.org/jira/browse/TS, and then attach the patch there. > > Brian > > > On Fri, Oct 25, 2013 at 4:37 PM, Thomas Jackson

Remap/regex_remap consolidation

ut these specifics please let me know-- we're hoping to nail down the markup fairly quickly and get this taken care of in the next few weeks. If you have questions about what markup would look like (and don't want to spam the mailing list) feel free to mail me individually or PM me on IRC (jacksontj). Thomas Jackson Traffic SRE @ LinkedIn

Re: Remap/regex_remap consolidation

Another consideration for having >1 regex (which may or may not be premature optimization) is that if you have seperate regexes we can create hash maps similar to how maps work (a hashmap of domain_regex -> list of path regexes) which would make overall remap performance faster/better. On Tue, Ma

Re: Remap/regex_remap consolidation

te regexes for host and path, this is a non-issue. > > Maybe you can do separate regexes but let expansions cross over? $h[1] for > a host group etc. > > Pros and cons :) > > -- Leif > > > > > Brian > > > >> On Tuesday, March 25, 2014, Thomas Jackson

Re: [VOTE] Release Apache Traffic Server 4.2.1 (RC0)

+1 Builds in my environment and passes some basic smoke tests :) On Sat, Apr 12, 2014 at 6:14 PM, Phil Sorber wrote: > Hello All, > > I've prepared a release for v4.2.1 (RC0) which is the latest stable release > in the 4.2.x series. This is the second release in our Long Term Support > (LTS) v

Re: git submodule issues

I'd prefer to keep it as a submodule because it will make porting fixes etc significantly easier. Do we have any specifics about the problems in the build systems? I use git submodules for some tooling internally-- so I might be able to give a hand. The submodule stuff has been there for a while so

Re: [VOTE] Release Apache Traffic Server 4.2.1 (RC1)

+1 build and runs on my RHEL 6.4 box On Mon, Apr 21, 2014 at 9:37 AM, Phil Sorber wrote: > Hello All, > > I've prepared a release for v4.2.1 (RC1) which is the latest stable > release in the 4.2.x series. This is the second release in our Long Term > Support (LTS) version as detailed in our Rel

Re: unstable hash keys in tsqa

Hmm, that is odd. I meant to go clean that up since hash() isn't really a great hash (its the one used for dict hashing-- so it is fast but has collisions). I did some quick looking and couldn't see *why* it would have different hashes for the same input, but since we shouldn't the builtin hash for

Re: pass env variable to traffic_server via traffic_cop

Linux will unset LD_LIBRARY_PATH (as well as some other env variables) when you change users (decent explanation: http://superuser.com/questions/153420/why-does-my-ld-library-path-get-unset-when-using-screen-with-bash). The only way to get around this is to *not* change the user id between traffic_

Re: Adding Gzip/Gunzip feature in ATS core

+1 to the API in the core. Although I'm generally against features in the core-- this one makes a lot of sense. We only want/need to uncompress the data if the specific transaction has a transformation hook. In the core we can check and then uncompress it once for all of them, then re-compress it o