Once this process is in "officially" I can set up some subset of jenkins tests to run on opened/updated PRs. We could (for example) run a clang check, regression, and tsqa on centos. The goal would not be complete coverage, but some output to give the reviewer some more confidence it will work. This would mimic what I see for some of the other OpenSource projects I work on, and I'd be glad to take the time to set it up :)
On Tue, Nov 17, 2015 at 4:33 PM, Leif Hedstrom <zw...@apache.org> wrote: > > > On Nov 17, 2015, at 3:11 PM, Nick Kew <n...@apache.org> wrote: > > > > On Tue, 17 Nov 2015 10:29:17 -0800 > > Leif Hedstrom <zw...@apache.org> wrote: > > > >> Hi all, > >> > >> we have a proposal that all code commits going forward goes through a > step of Github pull requests. > > > > I'm happy with that in principle. Reads like a classic github workflow. > > > > But this reads like a decision that's been made and is being passed down. > > Did I miss on-list discussion leading to it? > > > > Also, lets consider this thread the discussion thread :). > > — Leif > >
