scw00 commented on issue #6674:
URL: https://github.com/apache/trafficserver/issues/6674#issuecomment-616257386
Can you please test with #5929
This is an automated message from the Apache Git Service.
To respond to the messa
vmamidi commented on issue #6674:
URL: https://github.com/apache/trafficserver/issues/6674#issuecomment-616318181
> Can you please test with #5929
We aren't able to reproduce the problem. We can try #6507 to invalidate the
object.
We noticed that it is the end bytes that is h
chn-lee-yumi opened a new issue #6684:
URL: https://github.com/apache/trafficserver/issues/6684
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
masaori335 commented on issue #:
URL: https://github.com/apache/trafficserver/pull/#issuecomment-616367367
I agree with this is an ugly hack:(
I still don't know what is root cause, but this looks LLD specific issue
with debug build. If I use GNU ld instead of LLD, the issue
masaori335 edited a comment on issue #:
URL: https://github.com/apache/trafficserver/pull/#issuecomment-616367367
I agree with this is an ugly hack:(
I still don't know what is root cause, but this looks LLD specific issue
with debug build. If I use GNU ld instead of LLD, th
maskit commented on issue #:
URL: https://github.com/apache/trafficserver/pull/#issuecomment-616421557
I looked into this too. Here's a couple of findings:
- Optimization does some magic. If I add `-O1` to AM_CPPFLAGS on
http2/Makefile.am then link succeeds without the LDADD
traeak commented on issue #6571:
URL: https://github.com/apache/trafficserver/pull/6571#issuecomment-616596029
[approve ci autest]
This is an automated message from the Apache Git Service.
To respond to the message, please lo
traeak opened a new pull request #6685:
URL: https://github.com/apache/trafficserver/pull/6685
Backport PR to make the autests simpler and more resilient.
This is an automated message from the Apache Git Service.
To respond t
shinrich opened a new pull request #6686:
URL: https://github.com/apache/trafficserver/pull/6686
@randall found memory leaks in a previous hostDB fix I pushed
153c08166ed3ba83f92064e607b37210fa34c297.
I spent quite a bit of time last winter tracking down HostDB events that
would tri
randall commented on a change in pull request #6686:
URL: https://github.com/apache/trafficserver/pull/6686#discussion_r411484138
##
File path: iocore/hostdb/HostDB.cc
##
@@ -1420,37 +1418,38 @@ HostDBContinuation::dnsEvent(int event, HostEnt *e)
return EVENT_CONT;
duke8253 commented on issue #6602:
URL: https://github.com/apache/trafficserver/pull/6602#issuecomment-616643314
I'm fine with either, I'll revert back to not changing the names then?
This is an automated message from the Apa
randall commented on issue #6667:
URL: https://github.com/apache/trafficserver/pull/6667#issuecomment-616644622
[approve ci autest]
This is an automated message from the Apache Git Service.
To respond to the message, please l
randall removed a comment on issue #6667:
URL: https://github.com/apache/trafficserver/pull/6667#issuecomment-616644622
[approve ci autest]
This is an automated message from the Apache Git Service.
To respond to the message,
randall removed a comment on issue #6663:
URL: https://github.com/apache/trafficserver/pull/6663#issuecomment-614150227
[approve ci autest]
This is an automated message from the Apache Git Service.
To respond to the message,
zwoop commented on issue #6685:
URL: https://github.com/apache/trafficserver/pull/6685#issuecomment-616660085
Was this cherry-picked with "git cherry-pick -x" ?
This is an automated message from the Apache Git Service.
To res
traeak commented on issue #6685:
URL: https://github.com/apache/trafficserver/pull/6685#issuecomment-616665949
No I didn't do it that way at the time for whatever reason. I can redo this
PR if desired.
This is an automated
sudheerv commented on issue #6602:
URL: https://github.com/apache/trafficserver/pull/6602#issuecomment-616670924
> I don't think we should rename TSContScheduleOnPool() to be
TSContSchedule(). The function requires a pool and it makes more sense to have
the name TSContScheduleOnPool(). I h
sudheerv edited a comment on issue #6602:
URL: https://github.com/apache/trafficserver/pull/6602#issuecomment-616670924
> I don't think we should rename TSContScheduleOnPool() to be
TSContSchedule(). The function requires a pool and it makes more sense to have
the name TSContScheduleOnPool
sudheerv edited a comment on issue #6602:
URL: https://github.com/apache/trafficserver/pull/6602#issuecomment-616670924
> I don't think we should rename TSContScheduleOnPool() to be
TSContSchedule(). The function requires a pool and it makes more sense to have
the name TSContScheduleOnPool
shinrich commented on issue #6686:
URL: https://github.com/apache/trafficserver/pull/6686#issuecomment-616673451
Updated to address @randall's comments
This is an automated message from the Apache Git Service.
To respond to t
SolidWallOfCode commented on issue #6602:
URL: https://github.com/apache/trafficserver/pull/6602#issuecomment-616682942
Given what I suggested [a month
ago](https://github.com/apache/trafficserver/pull/6577#issuecomment-604720341)
I am glad to see @sudheerv and @bryancall have come around
shukitchan commented on issue #6571:
URL: https://github.com/apache/trafficserver/pull/6571#issuecomment-616684827
[approve ci autest]
This is an automated message from the Apache Git Service.
To respond to the message, pleas
shukitchan commented on a change in pull request #6571:
URL: https://github.com/apache/trafficserver/pull/6571#discussion_r411540669
##
File path: plugins/lua/ts_lua.c
##
@@ -26,36 +26,311 @@
#define TS_LUA_MAX_STATE_COUNT 256
+#define TS_LUA_STATS_TIMEOUT 1000 // 1s
Re
shinrich commented on a change in pull request #6645:
URL: https://github.com/apache/trafficserver/pull/6645#discussion_r411545401
##
File path: plugins/experimental/traffic_dump/traffic_dump.cc
##
@@ -597,9 +601,29 @@ global_ssn_handler(TSCont contp, TSEvent event, void
*edat
zwoop opened a new pull request #6687:
URL: https://github.com/apache/trafficserver/pull/6687
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
randall opened a new pull request #6688:
URL: https://github.com/apache/trafficserver/pull/6688
This was introduced in 58b154bb6f253ac8660bd778dd2bf43cb7b60687
This is an automated message from the Apache Git Service.
To resp
shinrich opened a new pull request #6689:
URL: https://github.com/apache/trafficserver/pull/6689
Addresses issue #6300. Details of crash discussed there. We have been
running with this patch since January. Forgot to push this once we verified
its efficacy.
shinrich opened a new pull request #6690:
URL: https://github.com/apache/trafficserver/pull/6690
The current logic will apply the host name and SNI name match check of the
host name would have triggered a SNI policy for verify_client or tls_versions.
After working with this in produc
zwoop commented on issue #6688:
URL: https://github.com/apache/trafficserver/pull/6688#issuecomment-616751195
I assume this is an 8.1.x candidate too ?
This is an automated message from the Apache Git Service.
To respond to t
randall commented on issue #6688:
URL: https://github.com/apache/trafficserver/pull/6688#issuecomment-616753640
> I assume this is an 8.1.x candidate too ?
I think so. It applies cleanly.
This is an automated message f
vmamidi commented on issue #6686:
URL: https://github.com/apache/trafficserver/pull/6686#issuecomment-616753827
If we are trying to fix #5952, I wonder why didn't HttpSM Continuation
cancel pending event when it died? If we think HttpSM canceling the pending DNS
event is working as expecte
randall commented on a change in pull request #6675:
URL: https://github.com/apache/trafficserver/pull/6675#discussion_r411628186
##
File path: tests/gold_tests/bigobj/bigobj.test.py
##
@@ -0,0 +1,129 @@
+'''
+Test client-side communication when GETting a very large object.
+''
traeak opened a new pull request #6691:
URL: https://github.com/apache/trafficserver/pull/6691
This tries to make the slice plugin smarter when origins do bad things to
assets without changing their path including:
* etag change
* last modified change
* content length change
randall commented on issue #6686:
URL: https://github.com/apache/trafficserver/pull/6686#issuecomment-616780380
Running under Instruments.app, I no longer see the HostDB continuation leak.
I do see an assert hit here:
```
Fatal: HttpSM.cc:2880: failed assertion `event == HTTP_TUNN
randall commented on issue #6686:
URL: https://github.com/apache/trafficserver/pull/6686#issuecomment-616780585
@zwoop Can you put this PR on docs and see if the leaks you were seeing go
away?
This is an automated message f
zwoop commented on issue #6658:
URL: https://github.com/apache/trafficserver/pull/6658#issuecomment-616797897
Cherry-picked to v9.0.x branch.
This is an automated message from the Apache Git Service.
To respond to the message
zwoop commented on issue #6688:
URL: https://github.com/apache/trafficserver/pull/6688#issuecomment-616798389
Cherry-picked to v9.0.x branch.
This is an automated message from the Apache Git Service.
To respond to the message
zwoop commented on issue #6688:
URL: https://github.com/apache/trafficserver/pull/6688#issuecomment-616798655
Cherry-picked to 8.1.x
This is an automated message from the Apache Git Service.
To respond to the message, please
zwoop commented on issue #6671:
URL: https://github.com/apache/trafficserver/issues/6671#issuecomment-616828607
is this still an issue with 8.1.x or 9.0.x ?
This is an automated message from the Apache Git Service.
To respond
mlibbey commented on issue #6674:
URL: https://github.com/apache/trafficserver/issues/6674#issuecomment-616865474
Should have noted (thanks @SolidWallOfCode ) in the original description
that range requests that are before the magic offset against good and bad
copies have the same good md5
shinrich commented on issue #6686:
URL: https://github.com/apache/trafficserver/pull/6686#issuecomment-616874375
@randall can you tell what event was delivered to the HttpTunnel that caused
the assert?
This is an automated
shinrich commented on issue #6686:
URL: https://github.com/apache/trafficserver/pull/6686#issuecomment-616874877
@vmamidi The problem isn't that HttpSM died. Rather that multiple events
were created for the HostDBContinutation, and the original logic was not
correctly tracking those event
masaori335 commented on issue #:
URL: https://github.com/apache/trafficserver/pull/#issuecomment-616881628
Thanks for looking.
> Optimization does some magic. If I add -O1 to AM_CPPFLAGS on
http2/Makefile.am then link succeeds without the LDADD change, but not -O0.
Th
masaori335 commented on issue #:
URL: https://github.com/apache/trafficserver/pull/#issuecomment-616890728
I pushed new commit which satisfies both of GNU ld & LLD without duplicated
lines.
This is an automated messa
maskit commented on issue #:
URL: https://github.com/apache/trafficserver/pull/#issuecomment-616900020
> I tried another order, moving libinkevent.a between libhttp2.a and
libhdrs.a. It also works.
This is interesting. You may already have tried this, but adding only a dup
l
masaori335 commented on issue #:
URL: https://github.com/apache/trafficserver/pull/#issuecomment-616931987
[approve ci centos]
This is an automated message from the Apache Git Service.
To respond to the message, pleas
masaori335 opened a new pull request #6692:
URL: https://github.com/apache/trafficserver/pull/6692
I saw below `-Wdeprecated-copy` warning with llvm-10 on macOS.
```
CXX traffic_cache_tool/traffic_cache_tool-CacheTool.o
traffic_cache_tool/CacheTool.cc:259:5: error: definition
masaori335 commented on issue #6692:
URL: https://github.com/apache/trafficserver/pull/6692#issuecomment-616989592
[approve ci autest]
This is an automated message from the Apache Git Service.
To respond to the message, pleas
masaori335 removed a comment on issue #6692:
URL: https://github.com/apache/trafficserver/pull/6692#issuecomment-616989592
[approve ci autest]
This is an automated message from the Apache Git Service.
To respond to the messag
ema commented on a change in pull request #6667:
URL: https://github.com/apache/trafficserver/pull/6667#discussion_r411995855
##
File path: doc/admin-guide/files/records.config.en.rst
##
@@ -2050,6 +2050,27 @@ Cache Control
The maximum age allowed for a stale response bef
SolidWallOfCode commented on issue #6674:
URL: https://github.com/apache/trafficserver/issues/6674#issuecomment-617134005
After that long discussion, my view is the fragment data is not corrupt, it
is too short. Essentially the last fragment is not in the table at all and
seeks that start
scw00 commented on issue #6674:
URL: https://github.com/apache/trafficserver/issues/6674#issuecomment-617140375
AFAICT. The cache updated case will use the old fragment table other than
the newest one which I try to fix in #5929 . So the seek request can not get
correct offsets from fragme
scw00 edited a comment on issue #6674:
URL: https://github.com/apache/trafficserver/issues/6674#issuecomment-617140375
AFAICT. The cache updated case will use the old fragment table other than
the newest one, This is what I try to fix in #5929 . So the seek request can
not get correct offs
randall commented on issue #6692:
URL: https://github.com/apache/trafficserver/pull/6692#issuecomment-617215454
[approve ci autest]
This is an automated message from the Apache Git Service.
To respond to the message, please l
ywkaras commented on a change in pull request #6692:
URL: https://github.com/apache/trafficserver/pull/6692#discussion_r412242666
##
File path: src/traffic_cache_tool/CacheTool.cc
##
@@ -255,6 +255,8 @@ class VolumeAllocator
: _config(config), _size(size), _deficit(defic
a-canary commented on a change in pull request #6650:
URL: https://github.com/apache/trafficserver/pull/6650#discussion_r412260462
##
File path: doc/developer-guide/internal-libraries/Extendible.en.rst
##
@@ -80,18 +80,19 @@ the type's constructor, destructor, and serializer. A
a-canary commented on a change in pull request #6650:
URL: https://github.com/apache/trafficserver/pull/6650#discussion_r412270168
##
File path: include/tscore/Extendible.h
##
@@ -575,6 +584,17 @@ sizeOf(size_t size = sizeof(Derived_t))
template Extendible::Extendible()
{
randall commented on issue #6686:
URL: https://github.com/apache/trafficserver/pull/6686#issuecomment-617243024
@shinrich It's 104 (`VC_EVENT_EOS` ?)
This is an automated message from the Apache Git Service.
To respond to the
zwoop commented on issue #6643:
URL: https://github.com/apache/trafficserver/pull/6643#issuecomment-617247564
Cherry-picked to 8.1.x
This is an automated message from the Apache Git Service.
To respond to the message, please
zwoop commented on issue #5387:
URL: https://github.com/apache/trafficserver/pull/5387#issuecomment-617248882
Moving out from 8.1.x, unless someone cares very strongly here and makes a
PR for the 8.1.x branch (this doesn't cherry-pick cleanly).
vmamidi commented on issue #6686:
URL: https://github.com/apache/trafficserver/pull/6686#issuecomment-617252588
> @vmamidi The problem isn't that HttpSM died. Rather that multiple events
were created for the HostDBContinutation, and the original logic was not
correctly tracking those event
zwoop commented on issue #:
URL: https://github.com/apache/trafficserver/pull/#issuecomment-617273848
Cherry-picked to 8.1.x
Cherry-picked to v9.0.x branch.
This is an automated message from the Apache Git Service.
shinrich opened a new issue #6693:
URL: https://github.com/apache/trafficserver/issues/6693
While reviewing code coverage on master after running unit tests, regression
tests, and autests, it looks like only the most basic aspects of FetchSM are
exercised. The header manipulation and chun
ywkaras commented on a change in pull request #6675:
URL: https://github.com/apache/trafficserver/pull/6675#discussion_r412387670
##
File path: tests/gold_tests/bigobj/bigobj.test.py
##
@@ -0,0 +1,129 @@
+'''
+Test client-side communication when GETting a very large object.
+''
zwoop commented on issue #6686:
URL: https://github.com/apache/trafficserver/pull/6686#issuecomment-617362114
Running on Docs now (hence the OnDocs labe :-).
This is an automated message from the Apache Git Service.
To respon
zwoop edited a comment on issue #6686:
URL: https://github.com/apache/trafficserver/pull/6686#issuecomment-617362114
Running on Docs now (hence the OnDocs label :-).
This is an automated message from the Apache Git Service.
T
zwoop commented on issue #6586:
URL: https://github.com/apache/trafficserver/pull/6586#issuecomment-617363302
Cherry-picked to v9.0.x branch.
This is an automated message from the Apache Git Service.
To respond to the message
zwoop commented on issue #6645:
URL: https://github.com/apache/trafficserver/pull/6645#issuecomment-617363172
This also needs 4d7aeb09f83e447b2d3112d23bb0a98ba32ca51d.
This is an automated message from the Apache Git Service.
zwoop commented on issue #6645:
URL: https://github.com/apache/trafficserver/pull/6645#issuecomment-617363535
Cherry-picked to v9.0.x branch.
This is an automated message from the Apache Git Service.
To respond to the message
zwoop commented on issue #6663:
URL: https://github.com/apache/trafficserver/pull/6663#issuecomment-617363790
Cherry-picked to v9.0.x branch.
This is an automated message from the Apache Git Service.
To respond to the message
randall opened a new pull request #6694:
URL: https://github.com/apache/trafficserver/pull/6694
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
djcarlin opened a new issue #6695:
URL: https://github.com/apache/trafficserver/issues/6695
proxy.config.net.max_connections_active_in isn't documented, has a default
value in ATS 9.x of 1 according to traffic_ctl config describe
---
shinrich commented on issue #6686:
URL: https://github.com/apache/trafficserver/pull/6686#issuecomment-617441629
The events are against the HostDBContinuations. The stale event cases were
against the deleted and possibly reallocated HostDBContiunations. So if the
HostDBContinuation can k
bryancall opened a new pull request #6696:
URL: https://github.com/apache/trafficserver/pull/6696
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
shinrich opened a new pull request #6697:
URL: https://github.com/apache/trafficserver/pull/6697
Addresses issue #6472. We've updated our /etc/sysconfig/trafficserver to
pass in the 2500 (the previous compiled in value). But if you start
traffic_server without that value in our environme
masaori335 commented on a change in pull request #6692:
URL: https://github.com/apache/trafficserver/pull/6692#discussion_r412563078
##
File path: src/traffic_cache_tool/CacheTool.cc
##
@@ -255,6 +255,8 @@ class VolumeAllocator
: _config(config), _size(size), _deficit(de
masaori335 commented on a change in pull request #6692:
URL: https://github.com/apache/trafficserver/pull/6692#discussion_r412563078
##
File path: src/traffic_cache_tool/CacheTool.cc
##
@@ -255,6 +255,8 @@ class VolumeAllocator
: _config(config), _size(size), _deficit(de
bryancall opened a new pull request #6698:
URL: https://github.com/apache/trafficserver/pull/6698
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
shukitchan opened a new pull request #1:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/1
Initial Code and Document Checkin
This is an automated message from the Apache Git Service.
To respond to the mes
shukitchan opened a new pull request #2:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/2
to redirect http redirect to https
This is an automated message from the Apache Git Service.
To respond to the me
rishabhc opened a new pull request #3:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/3
1. Updates app-deployment.yaml to work correctly with the newer versions of
K8s
2. Updates ats-deployment.yaml to work correctly with the newer versions of
K8s
---
shukitchan commented on pull request #3:
URL:
https://github.com/apache/trafficserver-ingress-controller/pull/3#issuecomment-640124126
thanks for the patch
This is an automated message from the Apache Git Service.
To respond
shukitchan merged pull request #3:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/3
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
rishabhc opened a new pull request #4:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/4
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
shukitchan merged pull request #4:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/4
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
rishabhc opened a new pull request #5:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/5
… setup guide
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
shukitchan merged pull request #5:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/5
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
shukitchan merged pull request #5:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/5
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
rishabhc opened a new pull request #6:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/6
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
shukitchan commented on a change in pull request #6:
URL:
https://github.com/apache/trafficserver-ingress-controller/pull/6#discussion_r441206067
##
File path: Dockerfile
##
@@ -36,6 +36,7 @@ RUN curl -L
https://www-us.apache.org/dist/trafficserver/trafficserver-8.0.7.tar
CO
shukitchan commented on pull request #6:
URL:
https://github.com/apache/trafficserver-ingress-controller/pull/6#issuecomment-645071984
1. I don't think we should include the exporter this way. Rather we should
perhaps use "submodule" ?
2. Can the prometheus/grafana live in its own name
rishabhc commented on pull request #6:
URL:
https://github.com/apache/trafficserver-ingress-controller/pull/6#issuecomment-645550432
Changes in the recent commits:
1. Removed all the files of ATS exporter and included it as a submodule in
the repo
2. Grafana and prometheus now will
shukitchan merged pull request #6:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/6
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
rishabhc opened a new pull request #7:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/7
ATS has been updated to version 8.0.8 in the Dockerfile. Various
functionalities have been tested, everything seems to be running fine.
--
bryancall opened a new pull request #8:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/8
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
shukitchan commented on pull request #8:
URL:
https://github.com/apache/trafficserver-ingress-controller/pull/8#issuecomment-649679293
👍
This is an automated message from the Apache Git Service.
To respond to the message, p
masaori335 opened a new pull request #1:
URL: https://github.com/apache/trafficserver-site/pull/1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
bryancall merged pull request #1:
URL: https://github.com/apache/trafficserver-site/pull/1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
98 matches
Mail list logo
