shinrich opened a new pull request #6686:
URL: https://github.com/apache/trafficserver/pull/6686


   @randall found memory leaks in a previous hostDB fix I pushed 
153c08166ed3ba83f92064e607b37210fa34c297.
   
   I spent quite a bit of time last winter tracking down HostDB events that 
would trigger after the original continuations had long died.  This was 
particularly bad in our forward proxy deployments where we didn't have control 
over the DNS servers.
   
   We got our internal 7 version stable in terms of eliminating the stale 
hostdb events and the major hostdb leak.  This PR is the functional changes 
between the two.  The event leak fixes involve better tracking the the 
scheduled events and making sure to cancel them before cleaning things up.
   
   Our internal version has been running with the asserts ensuring that the 
action->mutex == action.continuation->mutex.  So in this PR, I left the asserts 
but got rid of the odd second lock logic.  After staring at enough cores, I am 
convinced that those occurred in cases where the continuation had been deleted 
and reassigned. 
   
   I also removed the hostdb_insert_timeout.  That appeared to be remnants of 
obsolete logic.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to