GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/548
TS-4302 Adds more control over the event API to use
This also addresses the build problems on current Illumos, by prioritizing
the ports interface. But as such, it can now be useful to allow ov
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/549
TS-4299 Allows for the content length to be processed even with C: close
This might look clunky, but a) I tried to minimize the possible damage done
to the FetchSM and b) the additions done ear
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/549#issuecomment-205305115
Seems odd that having a method named FetchSM::has_body() is doing checks
on if the Connection: close header is there. The logic on the close header
should be
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/549#issuecomment-205306794
I can't argue with that, but I also don't know / understand how and why
this check is important, and why it was added.
---
If your project is set up for it, you ca
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/549#issuecomment-205308868
See e83b131b and TS-3049 for why the Connection: close logic was added.
https://issues.apache.org/jira/browse/TS-3049
---
If your project is set up for
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/549#issuecomment-205336202
I couldn't have a time to dig into the issue but it seems the real problem
here is that ``has_body()`` has a side effect. It initializes
``resp_content_length``, a
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/549#issuecomment-205338877
@maskit Exactly, that's why it hangs the client, because even though there
is a Content-Length header, the existence of Connection: close short circuits
the code, s
Github user sudheerv commented on the pull request:
https://github.com/apache/trafficserver/pull/549#issuecomment-205342076
:+1: from me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/549#issuecomment-205348459
I'm OK with this as a minimal fix for a point release. @zwoop are you
planning to come back and improve this?
---
If your project is set up for it, you can reply
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/548#issuecomment-205422265
This looks reasonable to me. Eventually it might make sense to make this
selection at run time?
Now that we have it, please update
``admin-guide/installat
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/544#issuecomment-205428396
Looks reasonable to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user silentdai commented on the pull request:
https://github.com/apache/trafficserver/pull/199#issuecomment-205446579
@zwoop
I am working with @SolidWallOfCode and we need this feature. Would you mind
if I take this work?
---
If your project is set up for it, you can repl
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/548#issuecomment-205451669
Thanks, yeah, I'll update the configuration. Yeah, it might make sense to
make this selection at runtime, but of course it must also check for the
existence of avai
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/548#issuecomment-205503484
Hmmm, I don't know that it makes sense to add that document, we don't
document most of the options in configure.ac, and there is a "help" message for
this new optio
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/548#issuecomment-205504075
OK. I was thinking that we would start (continue?) documenting build
process/dependencies/options more.
---
If your project is set up for it, you can reply to thi
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/548#issuecomment-205506347
@jpeach Agreed. Can you file another Jira, and ask jsime to add a section
to this document where we document all options to configure ? That makes more
sense than a
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/548
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/545
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/544
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user shenzhang920 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/541#discussion_r58474731
--- Diff: proxy/hdrs/URL.cc ---
@@ -1158,9 +1158,51 @@ url_parse_scheme(HdrHeap *heap, URLImpl *url, const
char **start, const char *en
ret
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/541#discussion_r58485657
--- Diff: proxy/hdrs/URL.cc ---
@@ -1158,9 +1158,51 @@ url_parse_scheme(HdrHeap *heap, URLImpl *url, const
char **start, const char *en
return PA
21 matches
Mail list logo
