[GitHub] trafficserver pull request: TS-3478: Indexing header representatio...

2016-01-05 Thread syucream
Github user syucream commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/391#discussion_r48837742 --- Diff: proxy/http2/HPACK.h --- @@ -153,9 +165,9 @@ int64_t decode_string(Arena &arena, char **str, uint32_t &str_length, const uint int6

[GitHub] trafficserver pull request: TS-3478: Indexing header representatio...

2016-01-05 Thread syucream
Github user syucream commented on the pull request: https://github.com/apache/trafficserver/pull/391#issuecomment-168982622 @maskit I concern about Http2DynamicTable too. I'll add IndexingTable layer and separate Http2DynamicTable and static table. --- If your project is set up for i

[GitHub] trafficserver pull request: TS-4109: fix ts.debug/ts.error problem...

2016-01-05 Thread shukitchan
Github user shukitchan commented on the pull request: https://github.com/apache/trafficserver/pull/403#issuecomment-168995777 This is closed by 874016357466879496ca08fa20960de1591be915 --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] trafficserver pull request: TS-4109: fix ts.debug/ts.error problem...

2016-01-05 Thread shukitchan
Github user shukitchan closed the pull request at: https://github.com/apache/trafficserver/pull/403 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] trafficserver pull request: TS-4109: fix ts.debug/ts.error problem...

2016-01-05 Thread shukitchan
GitHub user shukitchan reopened a pull request: https://github.com/apache/trafficserver/pull/403 TS-4109: fix ts.debug/ts.error problem with long string fix ts.debug/ts.error problem with long string in ts_lua plugin You can merge this pull request into a Git repository by running:

[GitHub] trafficserver pull request: TS-4109: fix ts.debug/ts.error problem...

2016-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/403 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: Add TSSslContextCreate method

2016-01-05 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/402#issuecomment-169014530 Looks good to me as well. Seems like a good and necessary change. I assume that the bulk of the diff'ed lines in SSLUtils are due to just moving functio

[GitHub] trafficserver pull request: Doc: Typo "inorder" -> "in order"

2016-01-05 Thread hnakamur
GitHub user hnakamur opened a pull request: https://github.com/apache/trafficserver/pull/405 Doc: Typo "inorder" -> "in order" You can merge this pull request into a Git repository by running: $ git pull https://github.com/hnakamur/trafficserver patch-2 Alternatively you can

[GitHub] trafficserver pull request: Doc: Typo "inorder" -> "in order"

2016-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/405 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4088: Add support for BoringSSL

2016-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/386 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: Add TSSslContextCreate method

2016-01-05 Thread biilmann
Github user biilmann commented on the pull request: https://github.com/apache/trafficserver/pull/402#issuecomment-169107617 > I assume that the bulk of the diff'ed lines in SSLUtils are due to just moving functions ahead of use and the functions themselves are unchanged (e.g., asn1_st