Github user syucream commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/391#discussion_r48837742
--- Diff: proxy/http2/HPACK.h ---
@@ -153,9 +165,9 @@ int64_t decode_string(Arena &arena, char **str,
uint32_t &str_length, const uint
int64_t encode_indexed_header_field(uint8_t *buf_start, const uint8_t
*buf_end, uint32_t index);
int64_t encode_literal_header_field(uint8_t *buf_start, const uint8_t
*buf_end, const MIMEFieldWrapper &header, uint32_t index,
- HpackFieldType type);
+ Http2DynamicTable &dynamic_table,
HpackFieldType type);
int64_t encode_literal_header_field(uint8_t *buf_start, const uint8_t
*buf_end, const MIMEFieldWrapper &header,
--- End diff --
I prefer `with_(indexed|new)_name`. I'll rename them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
