> On Feb 15, 2019, at 4:16 PM, Chris Lemmons wrote:
>
> Generally, I want CI builds for my draft PR. If I break the build, I
> want to know ideally before I ask folks to review it in earnest. As
> long as I'm not pushing so frequently that I tie up the CI, it should
> be ok, right?
>
We woul
Generally, I want CI builds for my draft PR. If I break the build, I
want to know ideally before I ask folks to review it in earnest. As
long as I'm not pushing so frequently that I tie up the CI, it should
be ok, right?
On Fri, Feb 15, 2019 at 3:39 PM Leif Hedstrom wrote:
>
>
>
> > On Feb 15, 20
> On Feb 15, 2019, at 2:43 PM, Walt Karas
> wrote:
>
> We could also create PRs in our forked repos instead of making a draft PR
> in the main shared repo.
That kinda defeats the purpose IMO. 1) You want to be able to easily
collaborate (having me chase down 40+ other repos, is futile) 2)
"Change the status to “Ready for review” near the bottom of your pull
request to remove the draft state and allow merging according to your
project’s settings. "
On Fri, Feb 15, 2019 at 3:58 PM Alan Carroll <
solidwallofc...@verizonmedia.com> wrote:
> The github documentation claimed you could re
The github documentation claimed you could remove the "draft" property from
a draft PR.
On Fri, Feb 15, 2019 at 3:43 PM Walt Karas
wrote:
> We could also create PRs in our forked repos instead of making a draft PR
> in the main shared repo.
>
> On Fri, Feb 15, 2019 at 3:37 PM Bryan Call wrote:
We could also create PRs in our forked repos instead of making a draft PR
in the main shared repo.
On Fri, Feb 15, 2019 at 3:37 PM Bryan Call wrote:
> I agree, if someone has code that is in a work in progress state then
> please use this feature. It would be nice if you could after the fact
>
I agree, if someone has code that is in a work in progress state then please
use this feature. It would be nice if you could after the fact change a PR to
a draft PR, but I don’t see an option to do that.
-Bryan
> On Feb 14, 2019, at 12:16 PM, Randall Meyer
> wrote:
>
> This looks like so
This looks like something good to explore using.
https://github.blog/2019-02-14-introducing-draft-pull-requests/