> On Feb 15, 2019, at 4:16 PM, Chris Lemmons <alfic...@gmail.com> wrote:
>
> Generally, I want CI builds for my draft PR. If I break the build, I
> want to know ideally before I ask folks to review it in earnest. As
> long as I'm not pushing so frequently that I tie up the CI, it should
> be ok, right?
>
We would turn it back on again when you turn it into a real PR. The point being
that you probably want to push frequently to these draft PRs, as in, I’m doing
a big change, and I want to do a lot of small, incremental commits.
—leif
> On Fri, Feb 15, 2019 at 3:39 PM Leif Hedstrom <zw...@apache.org> wrote:
>>
>>
>>
>>> On Feb 15, 2019, at 2:43 PM, Walt Karas <wka...@verizonmedia.com.INVALID>
>>> wrote:
>>>
>>> We could also create PRs in our forked repos instead of making a draft PR
>>> in the main shared repo.
>>
>> That kinda defeats the purpose IMO. 1) You want to be able to easily
>> collaborate (having me chase down 40+ other repos, is futile) 2) More
>> importantly, we lose the discussion thread if/ when you turn it into a real
>> PR. As amc points out, this is an important feature of the draft PRs, they
>> can be turned into real PRs once the “WIP” is over with.
>>
>> I haven’t managed to figure out how to turn off automatic builds for the
>> Draft PRs. However, there is a feature in jenkins, if you add a comment like
>> his, it *should* turn off automatic builds:
>>
>> [skip ci]
>>
>>
>> I have not tested this, and presumably, you’d want to add this as the first
>> comment before you actually submit the PR (otherwise, it’ll kick off
>> immediately).
>>
>> — leif
>>
>>>
>>> On Fri, Feb 15, 2019 at 3:37 PM Bryan Call <bc...@apache.org> wrote:
>>>
>>>> I agree, if someone has code that is in a work in progress state then
>>>> please use this feature. It would be nice if you could after the fact
>>>> change a PR to a draft PR, but I don’t see an option to do that.
>>>>
>>>> -Bryan
>>>>
>>>>
>>>>
>>>>> On Feb 14, 2019, at 12:16 PM, Randall Meyer
>>>>> <randallme...@yahoo.com.INVALID>
>>>> wrote:
>>>>>
>>>>> This looks like something good to explore using.
>>>>> https://github.blog/2019-02-14-introducing-draft-pull-requests/
>>>>
>>>>
>>
