Re: git commit: TS-2579: remove ipv4 limit on FetchSM and TSFetchUrl/TSFetchPages

2014-02-26 Thread Shu Kit Chan
i think at the very least in squid.(b)log, you can see the address of the client being the ip you set in the TSHttpConnect call. On Wed, Feb 26, 2014 at 5:02 PM, Leif Hedstrom wrote: > So, ACLs? Logging ? > > -- Leif > > > On Feb 26, 2014, at 5:57 PM, Brian Geffon wrote: > > > > It's set as t

Re: git commit: TS-2579: remove ipv4 limit on FetchSM and TSFetchUrl/TSFetchPages

2014-02-26 Thread Leif Hedstrom
So, ACLs? Logging ? -- Leif > On Feb 26, 2014, at 5:57 PM, Brian Geffon wrote: > > It's set as the connecting ip. > >> On Wednesday, February 26, 2014, Leif Hedstrom wrote: >> >> Curious , why is there an IP address at all in this API? What is the use >> case? >> >> -- Leif >> On Feb

Re: git commit: TS-2579: remove ipv4 limit on FetchSM and TSFetchUrl/TSFetchPages

2014-02-26 Thread Brian Geffon
It's set as the connecting ip. On Wednesday, February 26, 2014, Leif Hedstrom wrote: > Curious , why is there an IP address at all in this API? What is the use > case? > > -- Leif > > > On Feb 26, 2014, at 4:04 PM, James Peach wrote: > > > >> On Feb 26, 2014, at 10:19 AM, Shu Kit Chan > wrote:

Re: git commit: TS-2579: remove ipv4 limit on FetchSM and TSFetchUrl/TSFetchPages

2014-02-26 Thread Leif Hedstrom
Curious , why is there an IP address at all in this API? What is the use case? -- Leif > On Feb 26, 2014, at 4:04 PM, James Peach wrote: > >> On Feb 26, 2014, at 10:19 AM, Shu Kit Chan wrote: >> >> Just curious. Which plugins are using TSHttpConnect incorrectly as you >> indicated? > > The

Re: git commit: TS-2579: remove ipv4 limit on FetchSM and TSFetchUrl/TSFetchPages

2014-02-26 Thread James Peach
On Feb 26, 2014, at 10:19 AM, Shu Kit Chan wrote: > Just curious. Which plugins are using TSHttpConnect incorrectly as you > indicated? The SPDY and authproxy plugins pass the destination address to TSHttpConnect. > should we have jira open to fix them? yes probably > On Sun, Feb 23, 2014 at

Re: git commit: TS-2579: remove ipv4 limit on FetchSM and TSFetchUrl/TSFetchPages

2014-02-26 Thread Shu Kit Chan
Just curious. Which plugins are using TSHttpConnect incorrectly as you indicated? should we have jira open to fix them? On Sun, Feb 23, 2014 at 3:02 PM, James Peach wrote: > On Feb 23, 2014, at 10:47 AM, Brian Geffon wrote: > > > Doesn't the http connect parse headers anyway? > > Yep > > > Isn

Re: git commit: TS-2579: remove ipv4 limit on FetchSM and TSFetchUrl/TSFetchPages

2014-02-23 Thread James Peach
On Feb 23, 2014, at 10:47 AM, Brian Geffon wrote: > Doesn't the http connect parse headers anyway? Yep > Isn't the address only used for local host proxying? local host proxying? I followed the code a little way and I thought that it is the address the connection was accepted on? I used to th

Re: git commit: TS-2579: remove ipv4 limit on FetchSM and TSFetchUrl/TSFetchPages

2014-02-23 Thread Brian Geffon
Doesn't the http connect parse headers anyway? Isn't the address only used for local host proxying? Brian On Sunday, February 23, 2014, Shu Kit Chan wrote: > ESI plugin unfortunately still uses TSFetchUrl and therefore cannot handle > ipv6 client addresses. > > > On Sun, Feb 23, 2014 at 8:19 AM

Re: git commit: TS-2579: remove ipv4 limit on FetchSM and TSFetchUrl/TSFetchPages

2014-02-23 Thread Shu Kit Chan
ESI plugin unfortunately still uses TSFetchUrl and therefore cannot handle ipv6 client addresses. On Sun, Feb 23, 2014 at 8:19 AM, James Peach wrote: > On Feb 20, 2014, at 2:43 PM, kic...@apache.org wrote: > > > Repository: trafficserver > > Updated Branches: > > refs/heads/master d3e4614bf ->

Re: git commit: TS-2579: remove ipv4 limit on FetchSM and TSFetchUrl/TSFetchPages

2014-02-23 Thread James Peach
On Feb 20, 2014, at 2:43 PM, kic...@apache.org wrote: > Repository: trafficserver > Updated Branches: > refs/heads/master d3e4614bf -> d94a47ba8 > > > TS-2579: remove ipv4 limit on FetchSM and TSFetchUrl/TSFetchPages What's the use case for this fix? One thing I just noticed is that all my code