Re: merging github pull requests

2016-04-15 Thread Phil Sorber
Also pretty sure you have to set your apache email as your primary/public if you want it to show in merges. On Fri, Apr 15, 2016 at 12:06 PM Phil Sorber wrote: > Just found this: > > Keep my email address private > > We will use *psudae...@users.noreply.github.com > * when performing web-based G

Re: merging github pull requests

2016-04-15 Thread Phil Sorber
Just found this: Keep my email address private We will use *psudae...@users.noreply.github.com * when performing web-based Git operations and sending email on your behalf. If you want command line Git operations to use your private email you must set your email in Git

Re: merging github pull requests

2016-04-15 Thread Leif Hedstrom
> On Apr 15, 2016, at 11:22 AM, James Peach wrote: > > >> On Apr 15, 2016, at 10:09 AM, Leif Hedstrom wrote: >> >> >>> On Apr 15, 2016, at 9:34 AM, Brian Geffon wrote: >>> >>> I'm not thrilled with it either. I agree that the email addresses are >>> definitely not desireable, also I don't

Re: merging github pull requests

2016-04-15 Thread Phil Sorber
This is the stuff I wanted to talk about at the summit. I think we should hold off on merging stuff until we can talk about it next month. Also, fwiw, the email addresses seem to work sometimes and not others. So there must be a misconfiguration somewhere triggering this. On Fri, Apr 15, 2016 at

Re: merging github pull requests

2016-04-15 Thread Bret Palsson
Has anyone reached out to github to see if they can resolve the email address issue? Seems like with this type of integration, they should have considered this behavior. -Bret On Fri, Apr 15, 2016 at 10:09 AM, Leif Hedstrom wrote: > > > On Apr 15, 2016, at 9:34 AM, Brian Geffon wrote: > > > >

Re: merging github pull requests

2016-04-15 Thread James Peach
> On Apr 15, 2016, at 10:09 AM, Leif Hedstrom wrote: > > >> On Apr 15, 2016, at 9:34 AM, Brian Geffon wrote: >> >> I'm not thrilled with it either. I agree that the email addresses are >> definitely not desireable, also I don't like how it also produces a merge >> commit. > > > I can deal w

Re: merging github pull requests

2016-04-15 Thread Leif Hedstrom
> On Apr 15, 2016, at 9:34 AM, Brian Geffon wrote: > > I'm not thrilled with it either. I agree that the email addresses are > definitely not desireable, also I don't like how it also produces a merge > commit. I can deal with the merge commit, but the email addressing issues are not cool. W

Re: merging github pull requests

2016-04-15 Thread Brian Geffon
I'm not thrilled with it either. I agree that the email addresses are definitely not desireable, also I don't like how it also produces a merge commit. On Friday, April 15, 2016, James Peach wrote: > Hi all, > > I just merged PR #563 using the "merge and squash" button on github. I'm > pretty un