I'm not thrilled with it either. I agree that the email addresses are definitely not desireable, also I don't like how it also produces a merge commit.
On Friday, April 15, 2016, James Peach <jpe...@apache.org> wrote: > Hi all, > > I just merged PR #563 using the "merge and squash" button on github. I'm > pretty unhappy with the results, and I wonder whether we should stop > trying to use github to merge. > > The things I don't like are > > - github ate the Daniel's email address so the author is now "Daniel Xu < > dan...@users.noreply.github.com <javascript:;>>" > - The committer is my github account "James Peach <jor...@gmail.com > <javascript:;>>", rather than my Apache one > - The commit message contains the actual commit messages for 2 commits, > but one of those was already in master so this commit doesn't contain the > content matching the message. > - The commit message *also* contains the PR title and description. > - There's no way to preflight the commit and message to verify that it's > what I want. > > Anyone else have an opinion on this? > > J
