Re: [PROPOSAL] Restructuring the example directory and adding lua scripts to it

2019-05-24 Thread Shu Kit Chan
Currently, the existing examples may not have all 3 (C, CPP, LUA) versions available. Often it is just 1. On other note, for me, it is helpful to see multiple examples in the same language so I can copy and combine ideas from them when I need to write a new plugin for new functionality. Kit On F

Re: [PROPOSAL] Restructuring the example directory and adding lua scripts to it

2019-05-24 Thread Sudheer Vinukonda
Hmm..I typically use examples to find a relevant sample code for a use case I'm interested in. For example, if I'm looking to write a transform plugin, I'd try and find an existing example for transform. The C/CPP/LUA API is great, of course, but that's usually my second level of search.  >From

Re: [PROPOSAL] Restructuring the example directory and adding lua scripts to it

2019-05-24 Thread Bryan Call
+1 - I like it better. -Bryan > On May 24, 2019, at 9:42 AM, Shu Kit Chan wrote: > > Leif made a suggestion on the PR and suggested the following structure instead > >example/ >plugins/ >c-api/ >null-transform/ >cpp-api/ >...

Re: [PROPOSAL] Restructuring the example directory and adding lua scripts to it

2019-05-24 Thread Shu Kit Chan
Leif made a suggestion on the PR and suggested the following structure instead example/ plugins/ c-api/ null-transform/ cpp-api/ ... lua-api/ ... configs/ forward/ revers

Re: [PROPOSAL] Restructuring the example directory and adding lua scripts to it

2019-05-24 Thread Shu Kit Chan
Here is the PR for this change. https://github.com/apache/trafficserver/pull/5573 Thanks. Kit On Tue, May 21, 2019 at 12:29 PM Steven R. Feltner wrote: > > +1 > > On 5/21/19, 2:50 AM, "Shu Kit Chan" wrote: > > Notice: This email is from an external sender. > > > > Hi, > > During t

Re: [PROPOSAL] Restructuring the example directory and adding lua scripts to it

2019-05-21 Thread Steven R. Feltner
+1 On 5/21/19, 2:50 AM, "Shu Kit Chan" wrote: Notice: This email is from an external sender. Hi, During the spring summit, we discussed changing the structure example directory to include some lua scripts as well as other future works Here is my prop

Re: [PROPOSAL] Restructuring the example directory and adding lua scripts to it

2019-05-21 Thread Sudheer Vinukonda
+1 On Monday, May 20, 2019, 11:50:50 PM PDT, Shu Kit Chan wrote: Hi, During the spring summit, we discussed changing the structure example directory to include some lua scripts as well as other future works Here is my proposal - /example/plugins/ - I will move all existing plugin ex

Re: [PROPOSAL] Restructuring the example directory and adding lua scripts to it

2019-05-21 Thread Bryan Call
+1 - Sounds good -Bryan > On May 20, 2019, at 11:50 PM, Shu Kit Chan wrote: > > Hi, > > During the spring summit, we discussed changing the structure example > directory to include some lua scripts as well as other future works > > Here is my proposal - > > /example/plugins/ - I will move a

Re: [PROPOSAL] Restructuring the example directory and adding lua scripts to it

2019-05-21 Thread Leif Hedstrom
> On May 21, 2019, at 12:50 AM, Shu Kit Chan wrote: > > Hi, > > During the spring summit, we discussed changing the structure example > directory to include some lua scripts as well as other future works > > Here is my proposal - > > /example/plugins/ - I will move all existing plugin examp