+1 - I like it better.

-Bryan


> On May 24, 2019, at 9:42 AM, Shu Kit Chan <chanshu...@gmail.com> wrote:
> 
> Leif made a suggestion on the PR and suggested the following structure instead
> 
>    example/
>        plugins/
>            c-api/
>                null-transform/
>            cpp-api/
>                ...
>            lua-api/
>                ...
>        configs/
>            forward/
>            reverse/
>            transparent/
> 
> I think it is easier to find the c/c++/lua examples this way as well.
> 
> Any comments?
> 
> Kit
> 
> On Fri, May 24, 2019 at 12:47 AM Shu Kit Chan <chanshu...@gmail.com> wrote:
>> 
>> Here is the PR for this change.
>> https://github.com/apache/trafficserver/pull/5573
>> 
>> Thanks.
>> 
>> Kit
>> 
>> On Tue, May 21, 2019 at 12:29 PM Steven R. Feltner <sfelt...@godaddy.com> 
>> wrote:
>>> 
>>> +1
>>> 
>>> On 5/21/19, 2:50 AM, "Shu Kit Chan" <chanshu...@gmail.com> wrote:
>>> 
>>>    Notice: This email is from an external sender.
>>> 
>>> 
>>> 
>>>    Hi,
>>> 
>>>    During the spring summit, we discussed changing the structure example
>>>    directory to include some lua scripts as well as other future works
>>> 
>>>    Here is my proposal -
>>> 
>>>    /example/plugins/ - I will move all existing plugin examples underneath 
>>> here
>>>    /example/plugins/lua/ - I will put a few lua scripts as example here
>>>    /example/config/ - in future we can put some directories here showing
>>>    examples of configuration files (e.g. cache.config, ip_allow.config,
>>>    logging.yaml, etc)
>>> 
>>>    Any thoughts?
>>> 
>>>    Thanks.
>>> 
>>>    Kit
>>> 
>>> 

Reply via email to