Re: Proposal to update existing TS API : TSHttpTxnAborted

2021-06-07 Thread Bryan Call
Thank you for the PR and issue! I am OK with the change. It looks like there are some build issue with it on GitHub. Please make sure it passes all the tests: https://github.com/apache/trafficserver/pull/7901 Since it is an incompatible cha

Re: [E] Proposal to update existing TS API : TSHttpTxnAborted

2021-06-01 Thread Walt Karas
Oh I see, for cases where there is no status? On Tue, Jun 1, 2021 at 10:13 AM Walt Karas wrote: > Hmm, you can't use TSHttpHdrStatusGet() ? > > On Sat, May 29, 2021 at 9:19 AM Sanjay Singh > wrote: > >> Hi all, >> >> I'd like to propose a change to an existing TS API, "TSHttpTxnAborted". >> >>

Re: [E] Proposal to update existing TS API : TSHttpTxnAborted

2021-06-01 Thread Walt Karas
Hmm, you can't use TSHttpHdrStatusGet() ? On Sat, May 29, 2021 at 9:19 AM Sanjay Singh wrote: > Hi all, > > I'd like to propose a change to an existing TS API, "TSHttpTxnAborted". > > The current function signature: > TSReturnCode > TSHttpTxnAborted(TSHttpTxn txnp) > > Propsed change: > TSReturn

Proposal to update existing TS API : TSHttpTxnAborted

2021-05-29 Thread Sanjay Singh
Hi all, I'd like to propose a change to an existing TS API, "TSHttpTxnAborted". The current function signature: TSReturnCode TSHttpTxnAborted(TSHttpTxn txnp) Propsed change: TSReturnCode TSHttpTxnAborted(TSHttpTxn txnp, bool *client_abort) Currently, the purpose of the API is limited to providi