Re: Dealing with reverts on master

2018-08-23 Thread Derek Dagit
OK let me draft something for the wiki... On Thu, Aug 23, 2018 at 5:50 PM, Bryan Call wrote: > Sounds good, want to create one? > > -Bryan > > > > > On Aug 22, 2018, at 11:44 AM, Derek Dagit > wrote: > > > > +1 > > > > My cheat sheet for these rules is growing lengthy. Would it be a good > idea

Re: Dealing with reverts on master

2018-08-23 Thread Bryan Call
Sounds good, want to create one? -Bryan > On Aug 22, 2018, at 11:44 AM, Derek Dagit wrote: > > +1 > > My cheat sheet for these rules is growing lengthy. Would it be a good idea > to publish to the wiki? > > On Wed, Aug 22, 2018 at 1:23 PM, Bryan Call wrote: > >> +1 - sounds good >> >> -B

Re: Dealing with reverts on master

2018-08-22 Thread Derek Dagit
+1 My cheat sheet for these rules is growing lengthy. Would it be a good idea to publish to the wiki? On Wed, Aug 22, 2018 at 1:23 PM, Bryan Call wrote: > +1 - sounds good > > -Bryan > > > > > On Aug 9, 2018, at 4:15 PM, Leif Hedstrom wrote: > > > > We have a few commits that have been reverte

Re: Dealing with reverts on master

2018-08-22 Thread Bryan Call
+1 - sounds good -Bryan > On Aug 9, 2018, at 4:15 PM, Leif Hedstrom wrote: > > We have a few commits that have been reverted on Master, which requires a > second “revert” commit (because of the review requirements). This can cause > confusion, particularly on the ChangeLog / Release Notes,

Dealing with reverts on master

2018-08-09 Thread Leif Hedstrom
We have a few commits that have been reverted on Master, which requires a second “revert” commit (because of the review requirements). This can cause confusion, particularly on the ChangeLog / Release Notes, so I’d like to suggest we do the following: 1. When reverting something, make