Sounds good, want to create one? -Bryan
> On Aug 22, 2018, at 11:44 AM, Derek Dagit <der...@oath.com.INVALID> wrote: > > +1 > > My cheat sheet for these rules is growing lengthy. Would it be a good idea > to publish to the wiki? > > On Wed, Aug 22, 2018 at 1:23 PM, Bryan Call <bc...@apache.org> wrote: > >> +1 - sounds good >> >> -Bryan >> >> >> >>> On Aug 9, 2018, at 4:15 PM, Leif Hedstrom <zw...@apache.org> wrote: >>> >>> We have a few commits that have been reverted on Master, which requires >> a second “revert” commit (because of the review requirements). This can >> cause confusion, particularly on the ChangeLog / Release Notes, so I’d like >> to suggest we do the following: >>> >>> >>> 1. When reverting something, make sure to comment on the reverted >> PR that it has been reverted >>> 2. I’d also like that we prepend the string “REVERTED:” to the >> Subject line on this PR. >>> 3. Remove the Milestone from this PR, *IF* this commit was not in >> a release. >>> 4. On the revert PR, do not set a Milestone, *unless* this revert >> was done against a commit that already went into >>> >>> >>> Essentially, we should only see reverted commits in the changelogs if >> they have actually been released. IMO at least. >>> >>> — Leif >>> >> >> > > > -- > Derek
