+1 for this
There is probably a lot of context from earlier big-picture technical
discussions that I was missing when I tried to review one of the PRs.
Specific examples of code that would be improved or problems that would be
fixed would be really helpful in deciding if the changes make sense fo
I'd be fine with doing this in my already scheduled "AMC Tech Corner" slot.
On Mon, Apr 23, 2018 at 11:22 AM, Bryan Call wrote:
> We should have a breakout session on this at the ATS Summit because it
> doesn’t look like this is going to be resolved on the mailing list. We can
> summarize the b
We should have a breakout session on this at the ATS Summit because it doesn’t
look like this is going to be resolved on the mailing list. We can summarize
the breakout session on the mailing list and open it up for anyone else that
wants to add to the discussion.
-Bryan
> On Apr 20, 2018, a
I don't think Leif and Bryan are taking this seriously. For instance, I
went and checked the PRs dealing with BufferWriter formatting (3332). I
found one. In the same period, there was also a PR to deal with a compiler
problem with printf() (3476). One of these is dangerously unstable, the
other so
> On Apr 20, 2018, at 8:28 PM, Walt Karas wrote:
>
> A broader issue is that Alan had the impression there was a clear
> consensus to do this, and so proceeded to do a lot of work. We should
> understand how that happened.
Agreed, it’s very unfortunate, and I agree that we should focus this d
A broader issue is that Alan had the impression there was a clear
consensus to do this, and so proceeded to do a lot of work. We should
understand how that happened.
Walt
On Fri, Apr 20, 2018 at 7:22 PM, Leif Hedstrom wrote:
> Traveling, so keeping this short for now...
>
>> On Apr 20, 2018, at
Traveling, so keeping this short for now...
> On Apr 20, 2018, at 10:18 AM, Jason Kenny wrote:
>
> Is the concern bufferwritter or the use fo bufferwritter in TSDebug. I
> agree the "extra" value is small for TSDebug. I feel the use of
> bufferwritter is great within our code base.
Many of us
The documentation doesn’t mention Debug(), but you have talked that you would
like to see this as a complete replacement for Debug(). That also needs to be
discussed.
Open source projects (proxies, and https servers) I have looked at use printf()
or iostreams. I haven’t seen one that implemen
That is not an issue with modern compliers, like we use in CI:
regex_remap/regex_remap.cc: In function ‘TSRemapStatus TSRemapDoRemap(void*,
TSHttpTxn, TSRemapRequestInfo*)’:
regex_remap/regex_remap.cc:1114:18: error: format ‘%g’ expects argument of type
‘double’, but argument 2 has type ‘int’ [-
There are multiple concerns:
1. More code to maintain and more PRs to review
2. Complexity of the code is increased
3. Learning a new formatting and access to documentation - man snprintf vs
reading a webpage
4. Bugs in the implementation that haven’t been found yet, instead of using a
standard
For me the most important benefit is no undefined behavior / memory
corruption, like the kind you'd get from:
int i = 10;
TSError("%g", i);
On Fri, Apr 20, 2018 at 9:18 AM, Jason Kenny wrote:
> Is the concern bufferwritter or the use fo bufferwritter in TSDebug. I
> agree the "extra" value is sm
Is the concern bufferwritter or the use fo bufferwritter in TSDebug. I
agree the "extra" value is small for TSDebug. I feel the use of
bufferwritter is great within our code base.
-Jason
On Thu, Apr 19, 2018 at 5:42 PM, Bryan Call wrote:
> Replacing Debug()/TSDebug() with BufferWriter/bwformat
The document doesn't mention Debug() nor TSDebug().
I think the downsides of (1) having to do pre-string conversions for
non-builtin types such as IP Addresses and (2) having to select from a
confusing and sometimes (as in PR 3476) impossible to be cross platform
portable set of integer format cod
Replacing Debug()/TSDebug() with BufferWriter/bwformat has little benefit.
Also, I don’t think adding another formatting interface for strings is
something we want to maintain or use.
The main downside, with snprintf(), I see reading the examples is having to
keep track of the length and posit
I have several pull requests up currently involving updates to output
formatting for BufferWriter. I was asked to provide more detail on the
point of these pulls requests. Anyone who is interested can read this
document - https://solidwallofcode.github.io/buffer-writer.en.html for that
detail.
15 matches
Mail list logo
