There are multiple concerns: 1. More code to maintain and more PRs to review 2. Complexity of the code is increased 3. Learning a new formatting and access to documentation - man snprintf vs reading a webpage 4. Bugs in the implementation that haven’t been found yet, instead of using a standard solution that has been well vetted 5. Opportunity cost of spending time of this instead of fixing more important issues
-Bryan > On Apr 20, 2018, at 7:18 AM, Jason Kenny <jke...@oath.com.INVALID> wrote: > > Is the concern bufferwritter or the use fo bufferwritter in TSDebug. I > agree the "extra" value is small for TSDebug. I feel the use of > bufferwritter is great within our code base. > > -Jason > > On Thu, Apr 19, 2018 at 5:42 PM, Bryan Call <bc...@apache.org> wrote: > >> Replacing Debug()/TSDebug() with BufferWriter/bwformat has little >> benefit. Also, I don’t think adding another formatting interface for >> strings is something we want to maintain or use. >> >> The main downside, with snprintf(), I see reading the examples is having >> to keep track of the length and position in the buffer if you are calling >> snprintf() multiple times. This can be handled writing a simple wrapper >> around snprintf(), which I have done before in about 20 lines of code. If >> we want to expose a wrapper around snprintf(), I would be in favor of that. >> >> -Bryan >> >>> On Apr 19, 2018, at 11:20 AM, Alan Carroll >>> <solidwallofc...@oath.com.INVALID> >> wrote: >>> >>> I have several pull requests up currently involving updates to output >>> formatting for BufferWriter. I was asked to provide more detail on the >>> point of these pulls requests. Anyone who is interested can read this >>> document - https://solidwallofcode.github.io/buffer-writer.en.html for >> that >>> detail. >> >>
