[GitHub] trafficserver pull request: TS-4397: Fix build on i386 caused by t...

2016-04-30 Thread felixbuenemann
Github user felixbuenemann commented on the pull request: https://github.com/apache/trafficserver/pull/607#issuecomment-215986332 @shukitchan This was the only build problem on i386. I noticed it when building ubuntu packages on launchpad which builds for both i386 and x86-64. --- If

[GitHub] trafficserver pull request: TS-4397: Fix build on i386 caused by t...

2016-04-30 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/607 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] trafficserver pull request: TS-4397: Fix build on i386 caused by t...

2016-04-30 Thread shukitchan
Github user shukitchan commented on the pull request: https://github.com/apache/trafficserver/pull/607#issuecomment-215973625 it looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] trafficserver pull request: TS-4397: Fix build on i386 caused by t...

2016-04-30 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/607#issuecomment-215972974 @shukitchan We dropped 32-bit support as in, we don't have anyone who's maintaining / testing / supporting 32-bit. If someone (like Felix) wants to do it, and it c

[GitHub] trafficserver pull request: TS-4397: Fix build on i386 caused by t...

2016-04-30 Thread shukitchan
Github user shukitchan commented on the pull request: https://github.com/apache/trafficserver/pull/607#issuecomment-215972733 It looks fine. But I think we dropped 32 bit support already? so i doubt this is the only problem? @zwoop --- If your project is set up for it, you can r

[GitHub] trafficserver pull request: TS-4397: Fix build on i386 caused by t...

2016-04-30 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/607#issuecomment-215972662 Seems reasonable to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] trafficserver pull request: TS-4397: Fix build on i386 caused by t...

2016-04-29 Thread felixbuenemann
GitHub user felixbuenemann opened a pull request: https://github.com/apache/trafficserver/pull/607 TS-4397: Fix build on i386 caused by type mismatch It seems lua_Integer is 32-Bit on i386 while it's 54-Bit on x86-64 causing the existing code to fail with: ``` metrics.c