[GitHub] trafficserver pull request: TS-4397: Fix build on i386 caused by t...

[felixbuenemann]

GitHub user felixbuenemann opened a pull request:

    https://github.com/apache/trafficserver/pull/607

    TS-4397: Fix build on i386 caused by type mismatch

    It seems lua_Integer is 32-Bit on i386 while it's 54-Bit on x86-64 causing 
the existing code to fail with:
    
    ```
    metrics.cc: In function ‘bool 
metrics_binding_initialize(BindingInstance&)’:
    metrics.cc:339:58: error: call of overloaded ‘bind_constant(const char 
[20], int64_t)’ is ambiguous
       binding.bind_constant("metrics.update.pass", int64_t(0));
    ```
    
    See [Bug TS-4397](https://issues.apache.org/jira/browse/TS-4397) for more 
info.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/felixbuenemann/trafficserver TS-4397

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/607.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #607
    
----
commit 9cf86f300d525d1feb41b07afc9b87b44b6c7ec9
Author: Felix Bünemann <buenem...@louis.info>
Date:   2016-04-30T06:09:24Z

    Fix build on i386 caused by type mismatch
    
    It seems lua_Integer is 32-Bit on i386 while it's 54-Bit on x86-64
    causing the existing code to fail with:
    
    metrics.cc: In function ‘bool 
metrics_binding_initialize(BindingInstance&)’:
    metrics.cc:339:58: error: call of overloaded ‘bind_constant(const char 
[20], int64_t)’ is ambiguous
       binding.bind_constant("metrics.update.pass", int64_t(0));

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---