Github user maskit closed the pull request at:
https://github.com/apache/trafficserver/pull/551
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/551#issuecomment-209756115
I filed three Jiras.
https://issues.apache.org/jira/browse/TS-4349
https://issues.apache.org/jira/browse/TS-4350
https://issues.apache.org/jira/browse/TS
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/551#issuecomment-209208545
@maskit sound good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/551#issuecomment-209208239
I'm going to push this fix without the test tomorrow, and I'll file a Jira
for tests as a more general (but not too general) issue. Since tsqa has a test
for chunk
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/551#issuecomment-209163324
Fwiw, I'm running with this patch now on
{ci,docs}.trafficserver.apache.org, and it's fixing the issues I've seen on
e.g. https://ci.trafficserver.apache.org/
---
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/551#issuecomment-209159096
I don't think we should hold this back to enforce a tsqa test. However, I'd
suggest you file a separate Jira to add such a test. Curious: Does any of the
other H2 t
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/551#issuecomment-208206647
@jpeach I added a parameter to ``http2_generate_h2_header_from_1_1()`` to
pass a ``HTTPHdr`` declared in ``send_headers_frame()`` instead of creating it
with ``new
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/551#discussion_r59147631
--- Diff: proxy/http2/HTTP2.cc ---
@@ -498,25 +498,23 @@ http2_convert_header_from_2_to_1_1(HTTPHdr *headers)
return PARSE_DONE;
}
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/551#issuecomment-208089304
Assigned to peach for review, and we really need this landed for 6.2.0,
because it's completely crippling.
---
If your project is set up for it, you can reply to t
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/551#discussion_r58726866
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -1007,14 +1007,18 @@ Http2ConnectionState::send_headers_frame(FetchSM
*fetch_sm)
Debug
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/551#discussion_r58726540
--- Diff: proxy/http2/HTTP2.cc ---
@@ -498,25 +498,23 @@ http2_convert_header_from_2_to_1_1(HTTPHdr *headers)
return PARSE_DONE;
}
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/551#issuecomment-206137778
I just remembered tsqa. I'll try to write a test for this with tsqa.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/551#issuecomment-206128731
Though I tested it with nghttp and httpbin as an origin server, I think we
can test with nghttp/curl and nc. But if you mean automated tests, I have no
idea.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/551#issuecomment-206111521
Is this testable? It seems like we really need a regression test here ...
---
If your project is set up for it, you can reply to this email and have your
reply app
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/551
TS-4321: Keep response headers in FetchSM as they are
https://issues.apache.org/jira/browse/TS-4321
You can merge this pull request into a Git repository by running:
$ git pull https://gi
15 matches
Mail list logo
