Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/551#discussion_r58726866
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -1007,14 +1007,18 @@ Http2ConnectionState::send_headers_frame(FetchSM
*fetch_sm)
DebugHttp2Stream(ua_session, stream->get_id(), "Send HEADERS frame");
- http2_convert_header_from_1_1_to_2(resp_header);
- buf_len = resp_header->length_get() * 2; // Make it double just in case
+ HTTPHdr *h2_hdr = http2_generate_h2_header_from_1_1(resp_header);
--- End diff --
I think we should probably avoid the malloc by using an out parameter for
the HTTP2 copy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
