Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/541#issuecomment-210576382
Hey @shenzhang920 why did you close the pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user shenzhang920 closed the pull request at:
https://github.com/apache/trafficserver/pull/541
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/541#issuecomment-209762909
I'm ok with ``ParseRules::is_uri``. I made a couple of comments on the
tests.
Please take a look at [this](http://chris.beams.io/posts/git-commit/)
articl
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/541#discussion_r59663241
--- Diff: proxy/hdrs/URL.cc ---
@@ -1846,4 +1823,42 @@ REGRESSION_TEST(VALIDATE_HDR_FIELD)(RegressionTest
*t, int /* level ATS_UNUSED *
}
}
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/541#discussion_r59663226
--- Diff: proxy/hdrs/URL.cc ---
@@ -1846,4 +1823,42 @@ REGRESSION_TEST(VALIDATE_HDR_FIELD)(RegressionTest
*t, int /* level ATS_UNUSED *
}
}
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/541#discussion_r59663218
--- Diff: proxy/hdrs/URL.cc ---
@@ -1846,4 +1823,42 @@ REGRESSION_TEST(VALIDATE_HDR_FIELD)(RegressionTest
*t, int /* level ATS_UNUSED *
}
}
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/541#issuecomment-209696367
Thanks @shenzhang920
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user shenzhang920 commented on the pull request:
https://github.com/apache/trafficserver/pull/541#issuecomment-209688326
@bgaff I search the code, no usage of is_wildmat()/is_wildmat_BIT. @jpeach
any suggestion to the name "is_uri"?
---
If your project is set up for it, you c
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/541#issuecomment-209687483
:+1: This looks good to me, one concern would be the bit name is_uri, can
we find a more descriptive name for this bit? Also, @shenzhang920 you also
confirmed there
Github user shenzhang920 commented on the pull request:
https://github.com/apache/trafficserver/pull/541#issuecomment-209686860
@jpeach I removed is_wildmat_BIT and added is_uri_BIT, please refer to
commit d9d972d
---
If your project is set up for it, you can reply to this email and
Github user shenzhang920 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/541#discussion_r59641878
--- Diff: proxy/hdrs/URL.cc ---
@@ -1158,9 +1158,51 @@ url_parse_scheme(HdrHeap *heap, URLImpl *url, const
char **start, const char *en
ret
Github user shenzhang920 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/541#discussion_r59641766
--- Diff: mgmt/RecordsConfig.cc ---
@@ -441,6 +441,8 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG, "proxy.config.ht
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/541#issuecomment-208686127
I definitely think that ``ParseRules.cc`` is the right place for this. I
suggest we reclaim one of the obsolete bits for this?
---
If your project is set up for i
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/541#issuecomment-208488556
@jpeach I looked into the idea of using ParseRules.cc and CompileParseRules
with @shenzhang920 but it does't look like there are any free bits at the
moment, shoul
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/541#discussion_r58485657
--- Diff: proxy/hdrs/URL.cc ---
@@ -1158,9 +1158,51 @@ url_parse_scheme(HdrHeap *heap, URLImpl *url, const
char **start, const char *en
return PA
Github user shenzhang920 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/541#discussion_r58474731
--- Diff: proxy/hdrs/URL.cc ---
@@ -1158,9 +1158,51 @@ url_parse_scheme(HdrHeap *heap, URLImpl *url, const
char **start, const char *en
ret
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/541#discussion_r57665851
--- Diff: proxy/hdrs/HTTP.cc ---
@@ -878,7 +878,7 @@ http_parser_clear(HTTPParser *parser)
MIMEParseResult
http_parser_parse_req(HTTPPars
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/541#discussion_r57665801
--- Diff: proxy/hdrs/URL.cc ---
@@ -1158,9 +1158,51 @@ url_parse_scheme(HdrHeap *heap, URLImpl *url, const
char **start, const char *en
return PA
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/541#discussion_r57665768
--- Diff: mgmt/RecordsConfig.cc ---
@@ -441,6 +441,8 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG, "proxy.config.http.pos
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/541#discussion_r57665750
--- Diff: proxy/hdrs/URL.cc ---
@@ -1158,9 +1158,51 @@ url_parse_scheme(HdrHeap *heap, URLImpl *url, const
char **start, const char *en
return PA
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/541#discussion_r57665721
--- Diff: proxy/hdrs/URL.cc ---
@@ -1158,9 +1158,51 @@ url_parse_scheme(HdrHeap *heap, URLImpl *url, const
char **start, const char *en
return PA
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/541#discussion_r57665699
--- Diff: proxy/hdrs/URL.cc ---
@@ -1158,9 +1158,51 @@ url_parse_scheme(HdrHeap *heap, URLImpl *url, const
char **start, const char *en
return PA
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/541#issuecomment-202657737
This is actually how haproxy and nginx behave by default, this config
option is disabled by default for backwards compatibility.
---
If your project is set up for
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/541#issuecomment-202656925
I worked with @shenzhang920 on this and it looks good to me. :+1: from me.
@zwoop , mind taking a look?
---
If your project is set up for it, you can repl
GitHub user shenzhang920 opened a pull request:
https://github.com/apache/trafficserver/pull/541
TS-4312: Adding config to parse urls according to RFC
Adding a config option "proxy.config.http.strict_uri_parsing" to sends http
status code 400 back to client if the URL includes non-R
25 matches
Mail list logo
