Github user shenzhang920 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/541#discussion_r59641878
--- Diff: proxy/hdrs/URL.cc ---
@@ -1158,9 +1158,51 @@ url_parse_scheme(HdrHeap *heap, URLImpl *url, const
char **start, const char *en
return PARSE_ERROR; // no non-whitespace found
}
+static bool
+url_init_non_encoded_char_array(char *non_encoded_char, size_t size)
+{
+ const char *allowed_char = ":/?#[]@" // gen-delims
+ "!$&'()*+,;=" // sub-delims
+ "ABCDEFGHIJKLMNOPQRSTUVWXYZ" // ALPHA
+ "abcdefghijklmnopqrstuvwxyz"
+ "0123456789" // DIGIT
+ "-._~" // other
unreserved
+ "%"; // '%' should
also not be encoded
+
+ memset(non_encoded_char, 0, size);
+ for (size_t i = 0; i < strlen(allowed_char); ++i) {
+ ink_assert((unsigned char)allowed_char[i] < size);
+ non_encoded_char[(unsigned char)allowed_char[i]] = 1;
+ }
+
+ return true;
+}
+
+static char non_encoded_char[256];
+static bool url_init_non_encoded_char_array_done =
url_init_non_encoded_char_array(non_encoded_char, sizeof(non_encoded_char));
+
+/**
+ * This method will return TRUE if the uri is strictly compliant with
+ * RFC 3986 and it will return FALSE if not.
+ */
+static bool
+url_is_strictly_compliant(const char *start, const char *end)
+{
+ for (const char *i = start; i < end; ++i) {
+ if (!non_encoded_char[(unsigned char)*i]) {
+ Debug("http", "Non-RFC compliant character [0x%.2X] found in URL\n",
(unsigned char)*i);
+ return false;
+ }
+ }
+ return true;
+}
+
MIMEParseResult
-url_parse(HdrHeap *heap, URLImpl *url, const char **start, const char
*end, bool copy_strings_p)
+url_parse(HdrHeap *heap, URLImpl *url, const char **start, const char
*end, bool copy_strings_p, bool strict_uri_parsing)
--- End diff --
Regression test added in commit d9d972d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
