Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/549
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/549#issuecomment-206109679
Yah this makes sense :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/549#issuecomment-205348459
I'm OK with this as a minimal fix for a point release. @zwoop are you
planning to come back and improve this?
---
If your project is set up for it, you can reply
Github user sudheerv commented on the pull request:
https://github.com/apache/trafficserver/pull/549#issuecomment-205342076
:+1: from me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/549#issuecomment-205338877
@maskit Exactly, that's why it hangs the client, because even though there
is a Content-Length header, the existence of Connection: close short circuits
the code, s
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/549#issuecomment-205336202
I couldn't have a time to dig into the issue but it seems the real problem
here is that ``has_body()`` has a side effect. It initializes
``resp_content_length``, a
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/549#issuecomment-205308868
See e83b131b and TS-3049 for why the Connection: close logic was added.
https://issues.apache.org/jira/browse/TS-3049
---
If your project is set up for
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/549#issuecomment-205306794
I can't argue with that, but I also don't know / understand how and why
this check is important, and why it was added.
---
If your project is set up for it, you ca
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/549#issuecomment-205305115
Seems odd that having a method named FetchSM::has_body() is doing checks
on if the Connection: close header is there. The logic on the close header
should be
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/549
TS-4299 Allows for the content length to be processed even with C: close
This might look clunky, but a) I tried to minimize the possible damage done
to the FetchSM and b) the additions done ear
10 matches
Mail list logo
