Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/454
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-184764643
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-184758654
+1 - Debugging code looks better now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-183178568
Please take another look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-182204034
I didn't know this one. Thanks!
I'll fix with this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-182203667
Sorry, you need to use
[##__VA_ARGS__](https://gcc.gnu.org/onlinedocs/cpp/Variadic-Macros.html).
---
If your project is set up for it, you can reply to this email
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-182203173
@jpeach I thought that too, but it has error in my box (CentOS7, gcc-4.8)
Diff: https://paste.apache.org/4tlm
Result: https://paste.apache.org/gnEb
--
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-182201097
You should not need both ``DebugHttp2StreamMsg`` and
``DebugHttp2StreamFmt``, since is it valid (widely implemented GCC extension)
to not pass any format arguments
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-182201082
(Because of I force pushed, James's comment is disappeared:\ )
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-182200775
@bryancall It looks good. But it totally needs 3 macros like below as far
as I tried.
```
#define DebugHttp2Con(ua_session, fmt, ...) \
Debug
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-182151443
I think it would make sense to have a DebugHttp2Stream that would be used
at the stream level and format both ids, which is most of the debugging.
---
If your
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-181738410
@jpeach Please take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-180258234
I agree with we should keep consistency. So, I'm going to keep current
names and debug tag in Http2ClientSession.
The problem is same name (DebugHttp2S
GitHub user masaori335 opened a pull request:
https://github.com/apache/trafficserver/pull/454
TS-4172: Cleanup debug logs of Http2ConnectionState
[TS-4172](https://issues.apache.org/jira/browse/TS-4172)
You can merge this pull request into a Git repository by running:
$ git pu
14 matches
Mail list logo
