Github user masaori335 commented on the pull request:

    https://github.com/apache/trafficserver/pull/454#issuecomment-182200775
  
    @bryancall It looks good. But it totally needs 3 macros like below as far 
as I tried.
    
    ```
    #define DebugHttp2Con(ua_session, fmt, ...) \
      DebugSsn(ua_session, "http2_con", "[%" PRId64 "] " fmt, 
ua_session->connection_id(), __VA_ARGS__);
    
    #define DebugHttp2StreamMsg(ua_session, stream_id, msg) \
      DebugSsn(ua_session, "http2_stream", "[%" PRId64 "] [%u]" msg, 
ua_session->connection_id(), stream_id);
    
    #define DebugHttp2StreamFmt(ua_session, stream_id, fmt, ...) \
      DebugSsn(ua_session, "http2_stream", "[%" PRId64 "] [%u]" fmt, 
ua_session->connection_id(), stream_id, __VA_ARGS__);
    ```
    
    Actually this is what we're doing in Http2ClientSession. See 
[Http2ClientSession.cc#L34-L36](https://github.com/apache/trafficserver/blob/master/proxy/http2/Http2ClientSession.cc#L34-L36).
    Is there better macros technics? Or is this just fine?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to