[GitHub] trafficserver pull request: TS-4043 Prevent bogus FQDN characters ...

2015-12-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/356 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4043 Prevent bogus FQDN characters ...

2015-11-30 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/356#issuecomment-160855795 > so split out validate_hdr_field which takes a char const* and make a regression test for that? yup --- If your project is set up for it, you can reply

[GitHub] trafficserver pull request: TS-4043 Prevent bogus FQDN characters ...

2015-11-30 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/356#issuecomment-160768214 James - so split out `validate_hdr_field` which takes a `char const*` and make a regression test for that? The use of `ats_ip_parse` is correct. I

[GitHub] trafficserver pull request: TS-4043 Prevent bogus FQDN characters ...

2015-11-30 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/356#issuecomment-160765501 Can you extract the guts of ```validate_hdr_host``` into a separate function and use that to add a regression test host validation? Are you sure that the t

[GitHub] trafficserver pull request: TS-4043 Prevent bogus FQDN characters ...

2015-11-30 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/356#discussion_r46189499 --- Diff: proxy/hdrs/HTTP.cc --- @@ -161,6 +161,14 @@ is_digit(char c) return ((c <= '9') && (c >= '0')); } +// test to se

[GitHub] trafficserver pull request: TS-4043 Prevent bogus FQDN characters ...

2015-11-30 Thread danobi
GitHub user danobi opened a pull request: https://github.com/apache/trafficserver/pull/356 TS-4043 Prevent bogus FQDN characters in host header Validate the host header string to prevent malformed hostnames from being let in. You can merge this pull request into a Git repository by

[GitHub] trafficserver pull request: TS-4043 Prevent bogus FQDN characters ...

2015-11-30 Thread danobi
Github user danobi commented on the pull request: https://github.com/apache/trafficserver/pull/355#issuecomment-160669072 Messed up the commit message -- going to redo this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] trafficserver pull request: TS-4043 Prevent bogus FQDN characters ...

2015-11-30 Thread danobi
Github user danobi closed the pull request at: https://github.com/apache/trafficserver/pull/355 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature