Github user SolidWallOfCode commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/356#discussion_r46189499
  
    --- Diff: proxy/hdrs/HTTP.cc ---
    @@ -161,6 +161,14 @@ is_digit(char c)
       return ((c <= '9') && (c >= '0'));
     }
     
    +// test to see if a character is a valid character for a host in a URI 
according to
    +// RFC 2396
    +inline static int
    +is_host_char(char c)
    +{
    +   return (ParseRules::is_alpha(c) || ParseRules::is_digit(c) || (c == 
'-') || (c == '.'));
    --- End diff --
    
    What about colons for IPv6 addresses?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to