Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-164817652
Thanks @zizhong
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-164656248
@jpeach , I noticed you have changed the some details of the last commit.
Thanks for your help. However, there is a bug that you introduced with the
changes.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/301
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-164642165
@jpeach Thanks for the useful comments. I've made a new commit on your
suggestions. Would you mind having another look?
---
If your project is set up for it, you
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-164354501
@jpeach I reviewed this latest commit and it lgtm. If you're cool w/ this
please go ahead and land it, otherwise I'm happy to do it in the next day or so.
---
If y
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-164354432
@jpeach , the option is added in the last commit as you asked. Please let
me know if you have any questions.
cc @bgaff
---
If your project is set up fo
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-161872963
This looks pretty good. in a previous comment I suggested sending a flags
field with the child rollback registration. Maybe that could be a way to
request that the
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-161340071
@jpeach you are right. Coping SSL related files can cause secure issues. In
my opinion, all the child files should not be copied. what do you think
handling it in
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-159695223
Ok the next thing we need to do is remove the ```cert_files_vec``` from all
the functions in ```SSLUtils.cc```. The way we can do this is to add another
callback t
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-159461198
@jpeach ,Sorry! You can see the lastest version of patch in this pull
request. I updated this old request rather than making a new one.
---
If your project is s
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-159418922
@zizhong Great! I don't see the new patch here though?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-159192050
@jpeach , after I rewrote the whole patch on your idea, I found it way more
clear and concise than before. Thank you for your great suggestions.
Let me know if
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-158775453
@jpeach Thanks for your reply.
When I said the marshaling APIs being unsuitable, I meant using the APIs
marshalling the Vec(which is configFileGroup).
Howe
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-158530197
Thanks, I'll review again next week.
I don't think I understand what you mean about the marshaling APIs being
unsuitable. Here's how you would use it to se
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-158368954
@jpeach I made another pull request with your helpful commits.
About the marshalling using APIs from MgmtMarshall, the marshalling API
uses va_lists which is
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-157786700
> 1. How to clean up the old watched children files correctly?
If you have a tree of ```Rollback``` objects, then any object in the tree
that is updated wo
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-157628406
Thanks @jpeach for the helpful comments.
For the protocol you suggested,
1. How to clean up the old watched children files correctly?
2. In a parent wi
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-157497990
- Remove _strlen and _memcpy usage (see TS-4029).
- In ConfigFileGroup(), use ats_strdup() rather than malloc+memcpy.
- In Rollback::createPathStr(
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-156361172
hey @jpeach , I updated the branch with your opinion. Would you mind taking
another look at it?
---
If your project is set up for it, you can reply to this email
GitHub user zizhong reopened a pull request:
https://github.com/apache/trafficserver/pull/301
TS-3960: traffic_line -x doesn't reload SSL certs content
traffic_line -x doesn't reload when SSL certs change file contents without
changing the file names.
You can merge this pull reque
Github user zizhong closed the pull request at:
https://github.com/apache/trafficserver/pull/301
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-151591704
The local manager can be used to send a message from ```traffic_server```
up to ```traffic_manager```. Look for ```RecMessageSend```. It's unfortunate
that ```RecM
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-151378498
Ok @jpeach : i'll bite on the proposal to allow server to send a message to
manager, perhaps the most general purpose way to do this is to allow server to
specify t
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-151318976
I don't think it is that complex. All the machinery for doing this exists,
it just needs to be tied together in a sightly different way. My view is that
this appro
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-151006054
@jpeach , the approach you're describing sounds incredibly complex given
the problem we're trying to solve.
---
If your project is set up for it, you can reply to
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-150896275
Thanks @jpeach for the comment. I'll consider about another way to handle
this.
---
If your project is set up for it, you can reply to this email and have your
r
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-150839902
ink_file_lmtime
- Should be named "ink_file_time".
- I don't see why we need to use ink_timezone() here, or anywhere else for
that matter.
- This should
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-147933555
I will review this. Hoping to get to it by the weekend of Oct 17th. There
are some style changes to make, but I'm mainly concerned about the integration
with the c
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-146427348
@zwoop @jpeach @SolidWallOfCode mind doing a review for me?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
GitHub user zizhong opened a pull request:
https://github.com/apache/trafficserver/pull/301
TS-3960: traffic_line -x doesn't reload SSL certs content
traffic_line -x doesn't reload when SSL certs change file contents without
changing the file names.
You can merge this pull request
30 matches
Mail list logo
