Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-157786700
> 1. How to clean up the old watched children files correctly?
If you have a tree of ```Rollback``` objects, then any object in the tree
that is updated would trigger the root of the tree and remove all the children.
You always know the parent of the watched children, so when you trigger on the
group, you get the parent and remove the children. IIRC you are already doing
this.
> 2. In a parent with all children style, the whole information can be
packed in one message
> instead of O(children) messages, which is more efficient on both time and
space.
Since the message to ```traffic_manager``` is asynchronous and not
performance sensitive, there's no need to try to optimize this. We need to
optimize for simplicity. When you use a single item per message, it is easy to
re-use the existing message marshaling code, and the code in the SSL layer that
collects all the child files is no longer needed.
Although I agree that the tree is more general than strictly necessary, I
think that the code for that will turn out to be fairly clean. I am OK with
file groups, but please add a back pointer from the file group to the parent
```Rollback``` so that the parent lookups can be avoided. Note that if you make
the ```ConfigFileGroup``` a member of ```Rollback``` then you basically have
the tree structure already, which is why I'm suggesting it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
