Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/295#issuecomment-141487839
Merged under TS-3827. Let's restore the flags check under a separate JIRA.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/295
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/295#issuecomment-141335350
@masaori335 LGTM.
We should restore the check only about flags. Other part in the commit
looks reasonable.
---
If your project is set up for it, you can
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/295#issuecomment-141334561
@jpeach OK, I'll add unit tests.
IMO, we should restore the check.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/295#issuecomment-141333600
This looks reasonable. Could you add a unit test for
```http2_are_frame_flags_valid()```, which should be straightforward now the
masks are correct.
I see
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/295#issuecomment-141332599
@maskit Could you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user masaori335 opened a pull request:
https://github.com/apache/trafficserver/pull/295
TS-3921: Fix MASKs of Frames
- [TS-3921](https://issues.apache.org/jira/browse/TS-3921)
- [TS-3827](https://issues.apache.org/jira/browse/TS-3827)
You can merge this pull request into
