Github user jpeach commented on the pull request:

    https://github.com/apache/trafficserver/pull/295#issuecomment-141333600
  
    This looks reasonable. Could you add a unit test for 
```http2_are_frame_flags_valid()```, which should be straightforward now the 
masks are correct.
    
    I see that ```http2_frame_header_is_valid()``` does't raise an error on 
invalid flags. Should we restore the check?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to