Github user SolidWallOfCode closed the pull request at:
https://github.com/apache/trafficserver/pull/206
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/206#issuecomment-107664507
There's no way to know whether a metric was set by ``traffic_line``. The
best you can do is to say whether a metric was set by a specific API, but
that's complex a
Github user sudheerv commented on the pull request:
https://github.com/apache/trafficserver/pull/206#issuecomment-107653612
I don't think there was a consensus yet (at least, not from my side).
AFAIK, my question above on persisting the source as traffic_line was not
addressed and wit
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/206#issuecomment-107638211
The chat concensus seemed to be to change this to NULL, DEFAULT, EXPLICIT,
ENV. I'll change "SRC" to "SOURCE" as well - I was tempted to have "RECS" which
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/206#issuecomment-107638604
Yes, I had the same conflict about ``RECS`` ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/206#issuecomment-107628793
The ``REC_SRC`` constants scan poorly, I think I'd prefer ``REC_SOURCE``.
``REC_SRC_NONE`` should be called ``REC_SOURCE_NULL`` to be consistent with
other naming.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/206#issuecomment-107280577
I don't have any particular thoughts on this, other than if we do this, we
also add an API to query into this "source" of a particular config. E.g.
TSMgmtSourceGet(
Github user sudheerv commented on the pull request:
https://github.com/apache/trafficserver/pull/206#issuecomment-107253803
A config set via traffic_line gets added to records.config as well, so the
source of the config changes after a TS restart. Depending on how that info is
used, t
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/206
TS-3650: Track configuration variable source.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver ts-36
