Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/206#issuecomment-107628793
The ``REC_SRC`` constants scan poorly, I think I'd prefer ``REC_SOURCE``.
``REC_SRC_NONE`` should be called ``REC_SOURCE_NULL`` to be consistent with
other naming. There's some semantic confusion about what ``REC_SRC_DEFAULT``
means. When ``traffic_manager`` sets variables, I don't think they should be
considered defaults.
I am sympathetic to @sudheerv's concerns about how useful this is. The
distinction between "hard-coded default" and "everything else" is clear, but
this change is attempting to track various nuances that are much murkier.
Does ``DiagsConfig::RegisterDiagConfig`` really have to register
everything? I expect that that superfluous now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
