Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/614
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/614#issuecomment-217023707
Besides the formatting it looks good. I was meaning from above that you
would have to check the allowed methods at the at the session level. I missed
the isEm
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/614#issuecomment-217023387
Yes, planning on running clang-format and squashing before mergin.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/614#issuecomment-217020754
Looks like it needs to be clang-formatted there are a few formatting issues.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/614#discussion_r62123967
--- Diff: proxy/http2/Http2SessionAccept.cc ---
@@ -38,19 +39,25 @@ Http2SessionAccept::~Http2SessionAccept()
void
Http2SessionAccept::accep
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/614#issuecomment-216965627
Just pushed another commit that moves the IP-based ip allow checking to the
SessionAccept superclass. Verified for IP-based and method-based policies.
The meth
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/614#issuecomment-216920012
Don't you need to check what is being denied at the higher level?
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/614#issuecomment-216918182
The method checks are done in HttpTransact. The acl_record is stored on
the ProxyClientTransaction object for that later check.
---
If your project is set up f
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/614#issuecomment-216916522
Where is the check on the method? Each individual stream would need to be
verified.
---
If your project is set up for it, you can reply to this email and hav
Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/614#discussion_r62066950
--- Diff: proxy/http2/Http2SessionAccept.cc ---
@@ -38,9 +39,22 @@ Http2SessionAccept::~Http2SessionAccept()
void
Http2SessionAccept::accept(
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/614#discussion_r61987839
--- Diff: proxy/http2/Http2SessionAccept.cc ---
@@ -38,9 +39,22 @@ Http2SessionAccept::~Http2SessionAccept()
void
Http2SessionAccept::accept(Ne
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/614#discussion_r61987763
--- Diff: proxy/http2/Http2SessionAccept.cc ---
@@ -38,9 +39,22 @@ Http2SessionAccept::~Http2SessionAccept()
void
Http2SessionAccept::accept(Ne
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/614#discussion_r61987639
--- Diff: proxy/http2/Http2SessionAccept.cc ---
@@ -38,9 +39,22 @@ Http2SessionAccept::~Http2SessionAccept()
void
Http2SessionAccept::accept(Ne
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/614#discussion_r61987633
--- Diff: proxy/http2/Http2SessionAccept.cc ---
@@ -50,7 +64,7 @@ Http2SessionAccept::accept(NetVConnection *netvc,
MIOBuffer *iobuf, IOBufferRead
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/614
TS-3485: Support ip_allow config for HTTP2
Actually enforce the ip-level ACL checks for HTTP2 and move to the accept
logic to make the decision before creating the session object.
You can m
15 matches
Mail list logo
