Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/614#discussion_r61987839
--- Diff: proxy/http2/Http2SessionAccept.cc ---
@@ -38,9 +39,22 @@ Http2SessionAccept::~Http2SessionAccept()
void
Http2SessionAccept::accept(NetVConnection *netvc, MIOBuffer *iobuf,
IOBufferReader *reader)
{
+ AclRecord *session_acl_record = NULL;
+ sockaddr const *client_ip = netvc->get_remote_addr();
+ IpAllow::scoped_config ipallow;
+ if (ipallow && (((session_acl_record = ipallow->match(client_ip)) ==
NULL) || (session_acl_record->isEmpty()))) {
+ ip_port_text_buffer ipb;
+ Warning("http2 client '%s' prohibited by ip-allow policy",
ats_ip_ntop(client_ip, ipb, sizeof(ipb)));
--- End diff --
Oh so this is fail-closed when there is no config? If that is the case,
then HTTP/1 should do the same thing. We should have a single function that
does this check for both protocols to avoid this kind of drift.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
