Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-220376319
.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219788326
After doing more reading here and on the net, I now agree with @pbchou in
his original approach. Core should use `optind = 1` and all the plugins should
b
Github user PSUdaemon commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219586815
Ok, well I assume @pbchou can take it from here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219586583
The missing ``optarg = NULL`` is just my fat fingers :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user PSUdaemon commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219586100
Missing the `optarg = NULL` in the global case on purpose?
Also, I think we do want that `ifdef` around the `optind`. And I looked it
up, we need to inc
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219573746
* ``getopt_long`` is implemented on all the platforms we support.
* ``:`` means the option takes an argument; it is not a GNU extension
Here's what we s
Github user pbchou commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219565721
When there is an issue, typically the second plugin in the list will have
corrupted values for its arguments as returned by getopt_long(). For example,
it might re
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219565432
Heh, and so we are full circle. @jpeach Exactly, and that's what @pbchou
said in an earlier post. To which I raised the concern about changing it to 0
(as the patch
Github user PSUdaemon commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219553317
Can you please explain "do not play well together"? The `:` makes that
option required I think. Also, most if not all of these plugins are
developed/tested/depl
Github user pbchou commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219549881
I think this depends on whether GNU extensions are being used or not since
the man page does say that you "must" reinitialize with optind = 0 if you go
back and fo
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219535666
``0`` is a GNU extension behaviour, from the [man
page](http://man7.org/linux/man-pages/man3/getopt.3.html):
```
... and wants to make use of GNU extensions
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219529521
But this patch is changing it to 0, which might be Linux only? But we do
use this inconsistently, but then again, many plug-ins might not be tested on
anything but
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219522840
IMHO resetting to 1 is the right fix. It should be safe to reset ``optind``
in ``plugin_load`` and remove all the plugin assumptions, since we guarantee
that plugi
Github user pbchou commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219485292
I can only speak for Linux. However, it should be noted that if you grep
for 'optind = 0' under plugins/ there are around ten other plugins already
using optind =
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219260120
@pbchou So a complication might be if we have platforms where "0" does not
make sense? Or do we feel comfortable that "0" is what we should set? Do we
have to #ifde
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219194924
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219191874
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219190150
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219186502
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219128077
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219127822
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
GitHub user pbchou reopened a pull request:
https://github.com/apache/trafficserver/pull/571
TS-3245 : Changes optind = 1 to optind = 0 for all plugins to ensure
that multiples plugins in the global plugin.config can co-exist
together. Note that all plugins we
Github user pbchou commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219127222
Oops hit the wrong button.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user pbchou closed the pull request at:
https://github.com/apache/trafficserver/pull/571
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user pbchou commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219125801
On the Linux man page, at least, the optind should be set to 0 instead of 1
if you are mixing GNU extensions vs traditional between different invocations.
If you s
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219113313
I spent some time looking at this. I think the change is correct and I
think it must be the plugin responsibility because we don't require plugins to
use
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-218928614
Upgraded git on all the build boxes, so try again [approve ci].
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-218906249
FreeBSD v10 build finished successfully. Details on
https://ci.trafficserver.apache.org/job/Github-FreeBSD/19/
---
If your project is set up for it, you can
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-218905456
Linux (CentOS7) build failed! Details on
https://ci.trafficserver.apache.org/job/Github-Linux/40/
---
If your project is set up for it, you can reply to thi
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-218904513
FreeBSD v10 build finished successfully. Details on
https://ci.trafficserver.apache.org/job/Github-FreeBSD/16/
---
If your project is set up for it, you can
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-218903158
Linux (CentOS7) build failed! Details on
https://ci.trafficserver.apache.org/job/Github-Linux/33/
---
If your project is set up for it, you can reply to thi
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-218903058
Another build needed [approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-218782597
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-218591913
Linux (CentOS7) build finished successfully. Details on
https://ci.trafficserver.apache.org/job/Github-Linux/14/
---
If your project is set up for it, you c
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-218588544
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-218586966
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-218525641
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-217458962
@jpeach Did you look at this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-214041833
Note to self: check what glibc does with ``optind=1``, which is the pattern
used by remap plugins.
---
If your project is set up for it, you can reply to this ema
GitHub user pbchou opened a pull request:
https://github.com/apache/trafficserver/pull/571
TS-3245 : Changes optind = 1 to optind = 0 for all plugins to ensure
that multiples plugins in the global plugin.config can co-exist
together. Note that all plugins were
40 matches
Mail list logo
