[GitHub] trafficserver pull request: TS-3155

2014-11-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/139 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-3155

2014-11-10 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/139#issuecomment-62421425 This looks pretty good. Please use `strncasecmp() == 0` instead of `!strncasecmp()`. The former is easier to read and consistent with the rest of the code.

[GitHub] trafficserver pull request: TS-3155

2014-11-10 Thread shinrich
GitHub user shinrich opened a pull request: https://github.com/apache/trafficserver/pull/139 TS-3155 Adding value_get_index to test for presence of value in MIME header field. Using it in the keep alive checks. There are other places in the code where this change can be used