Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/139#issuecomment-62421425
This looks pretty good. Please use `strncasecmp() == 0` instead of
`!strncasecmp()`. The former is easier to read and consistent with the rest of
the code.
I'm not sure whether `strncasecmp` is the right comparison operation here.
The code in `MIME.cc` uses a mixture of `strcasecmp` and the `ParseRules` API.
I suspect that `ptr_len_casecmp` would be the right API to use.
I'm not sure how involved it would be, but please consider adding a
regression test for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
